Skip to content

Loading…

Fix patterns - too general #921

Closed
wants to merge 2 commits into from

2 participants

@torbensky

The original ignore was far too general and results in eliminating packages named "db" or "project", for example. These are not that uncommon for package names. Also added a lot of other common, Playframework project related ignore patterns (Scala/Java/sbt/Eclipse).

torbensky added some commits
@torbensky torbensky Fix patterns from
The original ignore was far too general and results in eliminating packages named "db" or "project", for example. These are not that uncommon for package names. Also added a lot of other common, Playframework project related ignore patterns (Scala/Java/sbt/Eclipse).
2192516
@torbensky torbensky TW: Added missing bin/ ignore. d5ed9cd
@arcresu

Thanks, but could you remove the IDE/OS-specific rules? They belong in the various global templates like Global/Linux and Global/Eclipse rather than being duplicated in each template, as per out contributing guidelines.

@arcresu arcresu added a commit that closed this pull request
@torbensky torbensky Increase the specificity of PlayFramework rules
The original ignore was far too general and results in eliminating packages
named "db" or "project", for example. These are not that uncommon for package
names. Fixes #921.
a6cabef
@arcresu arcresu closed this in a6cabef
@arcresu arcresu added a commit that referenced this pull request
@arcresu arcresu Merge branch 'fix-921'
This is #921 without the addition of editor-specific rules.
655e5ba
@drothmaler drothmaler pushed a commit to drothmaler/gitignore that referenced this pull request
@torbensky torbensky Increase the specificity of PlayFramework rules
The original ignore was far too general and results in eliminating packages
named "db" or "project", for example. These are not that uncommon for package
names. Fixes #921.
a83491e
@drothmaler drothmaler pushed a commit to drothmaler/gitignore that referenced this pull request
@arcresu arcresu Merge branch 'fix-921'
This is #921 without the addition of editor-specific rules.
b5f440f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 14, 2014
  1. @torbensky

    Fix patterns from

    torbensky committed
    The original ignore was far too general and results in eliminating packages named "db" or "project", for example. These are not that uncommon for package names. Also added a lot of other common, Playframework project related ignore patterns (Scala/Java/sbt/Eclipse).
  2. @torbensky

    TW: Added missing bin/ ignore.

    torbensky committed
This page is out of date. Refresh to see the latest.
Showing with 37 additions and 12 deletions.
  1. +37 −12 PlayFramework.gitignore
View
49 PlayFramework.gitignore
@@ -1,19 +1,44 @@
+# General Java / Scala ignore
+*.class
+*.log
+
+
+# eclipse ignores
+.project
+.metadata
+.classpath
+*.tmp
+*.bak
+*.swp
+.settings/
+
+# Locally stored "Eclipse launch configurations"
+*.launch
+
# Ignore Play! working directory #
-bin
-db
-eclipse
-lib
-log
-logs
-modules
+bin/
+/db
+.eclipse
+/lib/
+/logs/
+/modules
precompiled
-project/project
-project/target
-target
-tmp
+/project/project
+/project/target
+/target
+tmp/**
+tmp/**/*
test-result
server.pid
*.iml
*.eml
-dist
+/dist/
.cache
+
+# sbt ignore
+.history/
+.lib/
+
+# Scala-IDE specific
+.scala_dependencies
+.worksheet
Something went wrong with that request. Please try again.