Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Simplify sass cache rules #945

Merged
merged 2 commits into from

3 participants

@arcresu
Collaborator

.sass-cache is the cache directory created by the Sass CSS preprocessor.

  • Compass extends Sass, and I would think that most people who use it know this, so it seems unnecessary to have a duplicate single-rule template for it.
  • Rails redirects the Sass cache to tmp/sass-cache, so it's handled by the existing rule for /tmp.
  • The Sass template was under Global/, but I think that whenever you have Sass files in your repository, you're going to want the rule in its gitignore file anyway. I don't feel strongly about this.
@afeld afeld commented on the diff
Global/SASS.gitignore
@@ -1,2 +0,0 @@
-### Sass Ignores - "Sassy CSS" http://sass-lang.com/
-*.sass-cache
@afeld
afeld added a note

This is .sass-cache in the other file... are there any files created with that extension, or just the directory?

@arcresu Collaborator
arcresu added a note

I'm pretty sure it's just the directory and this was a typo.

@afeld
afeld added a note

@gneatgeek Is that the case? 027e033

Yep, typo. Question though, is the assumption that everyone is using compass or that they should know to find the rules packaged along with the compass rules?

@arcresu Collaborator
arcresu added a note

No, this PR is combining Global/SASS.gitignore and Compass.gitignore into a new template Sass.gitignore. There won't be any specific mention of Compass after this change since Compass is an extension of Sass.

Gotcha. Not sure how I missed that other than it's early in the A.M. ^^; Thanks for doing this :) :+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gneatgeek

The Sass template was under Global/, but I think that whenever you have Sass files in your repository, you're going to want the rule in its gitignore file anyway.

I've almost always put it in both global and the project gitignore files, but looking back on it, I'm not convinced it belongs in global since Sass is more of a project specific thing as opposed to an operating system or favorite editor.

@arcresu arcresu merged commit 121cbc3 into github:master
@arcresu arcresu deleted the arcresu:sass-cache branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 20, 2014
  1. @arcresu
  2. @arcresu
This page is out of date. Refresh to see the latest.
View
2  Global/SASS.gitignore
@@ -1,2 +0,0 @@
-### Sass Ignores - "Sassy CSS" http://sass-lang.com/
-*.sass-cache
@afeld
afeld added a note

This is .sass-cache in the other file... are there any files created with that extension, or just the directory?

@arcresu Collaborator
arcresu added a note

I'm pretty sure it's just the directory and this was a typo.

@afeld
afeld added a note

@gneatgeek Is that the case? 027e033

Yep, typo. Question though, is the assumption that everyone is using compass or that they should know to find the rules packaged along with the compass rules?

@arcresu Collaborator
arcresu added a note

No, this PR is combining Global/SASS.gitignore and Compass.gitignore into a new template Sass.gitignore. There won't be any specific mention of Compass after this change since Compass is an extension of Sass.

Gotcha. Not sure how I missed that other than it's early in the A.M. ^^; Thanks for doing this :) :+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
View
2  Rails.gitignore
@@ -1,6 +1,4 @@
*.rbc
-*.sassc
-.sass-cache
capybara-*.html
.rspec
/log
View
0  Compass.gitignore → Sass.gitignore
File renamed without changes
Something went wrong with that request. Please try again.