New ignore's for magento and grails latest versions
Ignore Magento cache and local.xml
Merge remote-tracking branch 'upstream/master'
Ignored eclipse target dir
Ignore plugin's digest
Thanks for this. In the future, it would be better if you could submit different PRs for different templates.
Note that IDE-specific rules go under the relevant templates in Global/, so for example .iws should only appear in Global/JetBrains.gitignore, and not in the Grails template. Similar for the eclipse-specific rule.
For the Magento template, can you explain why api.php should be ignored by default?
This rule already exists three lines down.
Removed duplicate line
I would ignore api.php as part of the standard magento install as index.php
Moved eclipse and isw rules in Global/Eclipse and Global/JetBrains
This doesn't need to be here.
What will be the impact of removing this rule? Is it something specific to Grails 2.x that should actually still be there for older versions?
Grails will drop the compiled files into /target so IMHO it shouldn't be versioned.
I've left a couple of inline comments. Also, I'm sorry but I think I've changed my mind: could you please submit these as separate PRs (one per template) after all? The reason is that I'm not convinced that what we're doing with the Magento template is a good idea, and your other changes are independent of this concern.
It will make it a lot easier to advance this if you can explain the need for new rules (e.g. the file is cached data, or contains sensitive information, or something else), as per our contributing guidelines. Thanks!
See #985 for my reasoning about the Magento template.
The /target directory will be used to store grails produced packages;…
… i.e *war
I'll close this since the PR needs to be split up, and it's a bit hard to judge if these changes are a good idea. Feel free to open up new individual PRs if you're still interested in this. Thanks!