Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

ExtJS JavaScript Framework gitignore #976

Merged
merged 3 commits into from

2 participants

@DenJohX

Added gitignore for Sencha ExtJS,

ExtJS is a complete web app JavaScript Framework.
http://www.sencha.com/products/extjs/

@DenJohX DenJohX ExtJS JavaScript Framework gitignore
Added gitignore for Sencha ExtJS, a complete web app framework
http://www.sencha.com/products/extjs/
42f1a32
@arcresu
Collaborator

Thanks for this. I think that the comment in the template is too long and confusing; the fact that a file is used for development doesn't have much to do with whether it should be version controlled, but an automatically generated file should be ignored.

Are these bootstrap files generated at the top level of the project? I can think of another bootstrap.js which might clash elsewhere in a project, so you could perhaps change your rules to /bootstrap.js and /bootstrap.css. Or are these rules actually for bootstrap the UI framework after all, as opposed to the common sense of the word?

Is there any documentation on the type of files that should be ignored for ExtJS? Or examples of gitignores from real-life repos? These would help to demonstrate that the rules are useful.

@DenJohX

In development, ExtJS uses bootstrap.js (not the ui framework) for dynamic loading of .js modules that are later concatenated and minified for production.

Those bootstrap files are auto-generated every time you build or refresh the app via the sencha cmd utility http://www.sencha.com/products/sencha-cmd/download , and you shuld refresh your project every time you add or remove a file (that usually happens on git operations).

Here is an example of the file: https://github.com/loiane/sencha-extjs4-examples-architect/blob/master/ExtJS4DesktopMVC/bootstrap.js ,

If the bootstrap files are generated on top level or not, depends on the developer, as sencha cmd can generate single [1] or multi-page [2] projects

ExtJS has its own templates and themes, it can be combined with other ui libraries, but with heavy tweaking, as it has its very own, very integrated, set of widgets.

[1] http://docs.sencha.com/extjs/4.2.2/#!/guide/command_app
[2] http://docs.sencha.com/extjs/4.2.2/#!/guide/command_workspace

@arcresu
Collaborator

Thanks for clarifying about the bootstrap files. Judging by that example repository, it looks like bootstrap.json should also be ignored as part of the build process? What about .sencha? And where is the Sass cache directory?

The example you provided doesn't contain a .gitignore; can you find any examples of .gitignore files in real ExtJS projects? It's hard to judge if the template you've proposed is reasonable without any documentation or examples as reference.

@DenJohX

bootstrap.json is generated only once, at project start, and necessary for extjs. Its the same with .sencha, wich hosts the configurations for the build proccess, themes, etc.

As part of the build proccess, sencha cmd invokes sass in a temp directory, wich is auto-cleaned after build, and moves all the neccesary generated files to build directory (already ignored). So no need to igonre .sass-cache

Unfortunatedly, there is not a complete extjs project in github to show you. It seems that everyone develop ext on private repositories and just publish spare custom widgets or modules.

I'm willing to this gitignore to be useful for MVC ExtJS pattern (complete extjs projects, creted and managed with sencha cmd). And by my experience, those are the only necessary files to ignore.

Perhaps the comment is kinda confuse, I will try to edit it for better understanding.

@DenJohX

It should be cleaner now, I also changed the file name to be consise with the focus of this gitignore.

ExtJS can be used outside of a MVC project, and it has to ignore much more files, dependant on the structure created by the developer.

@arcresu
Collaborator

Thanks for fixing this, and sorry I forgot about it! I'm happy with the contents of the template now, but none of the other templates have a space in their name; can you get rid of the space? Then we can merge.

@arcresu arcresu merged commit 9f1a168 into github:master
@arcresu arcresu referenced this pull request from a commit
@arcresu arcresu Get rid of the space in the filename
Amends #976
8979b22
@arcresu
Collaborator

I renamed the file and merged. Thanks!

@DenJohX

I'd completely forgot about this!, Thanks @arcresu

@DenJohX DenJohX deleted the DenJohX:ExtJS_ignore branch
@trimeloni trimeloni referenced this pull request from a commit in trimeloni/gitignore
@arcresu arcresu Get rid of the space in the filename
Amends #976
29b9cb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 28, 2014
  1. @DenJohX

    ExtJS JavaScript Framework gitignore

    DenJohX authored
    Added gitignore for Sencha ExtJS, a complete web app framework
    http://www.sencha.com/products/extjs/
Commits on Mar 12, 2014
  1. @DenJohX
  2. @DenJohX
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 0 deletions.
  1. +7 −0 ExtJS MVC.gitignore
View
7 ExtJS MVC.gitignore
@@ -0,0 +1,7 @@
+# build directory for Sencha (ExtJS) projects
+build/
+
+
+# bootstrap files are regenerated by Sencha CMD on every build or refresh
+bootstrap.js
+bootstrap.css
Something went wrong with that request. Please try again.