Remove Results classes from Node gitignore #977

Merged
merged 1 commit into from Feb 28, 2014

Conversation

Projects
None yet
2 participants
Contributor

stuartpb commented Feb 28, 2014

These aren't really common patterns in the Node world, and if a Node project includes one of these types as files, they're as likely to want to include them in the project as not (*.csv is as likely to be a data source as *.json).

@stuartpb stuartpb Remove Results classes from Node gitignore
These aren't really common patterns in the Node world, and if a Node project includes one of these types as files, they're as likely to want to include them in the project as not (`*.csv` is as likely to be a data source as `*.json`).
6b8815d
Collaborator

arcresu commented Feb 28, 2014

Thanks, I agree with this change - the rules are too broad and as such are likely to catch legitimate data files. If anyone wants to re-introduce this run/build data section, it should be more specific about targeting files which are unwanted.

@arcresu arcresu added a commit that referenced this pull request Feb 28, 2014

@arcresu arcresu Merge pull request #977 from stuartpb/patch-2
Remove overly-permissive data file rules from Node template
b8f2b6d

@arcresu arcresu merged commit b8f2b6d into github:master Feb 28, 2014

stuartpb deleted the stuartpb:patch-2 branch Mar 1, 2014

@drothmaler drothmaler pushed a commit to drothmaler/gitignore that referenced this pull request May 27, 2014

@arcresu arcresu Merge pull request #977 from stuartpb/patch-2
Remove overly-permissive data file rules from Node template
c47a717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment