Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to comment on pull request #443

Closed
Aaron1011 opened this issue Dec 5, 2013 · 1 comment
Closed

Add ability to comment on pull request #443

Aaron1011 opened this issue Dec 5, 2013 · 1 comment

Comments

@Aaron1011
Copy link

It would be great if hub had the ability to create a comment on the pull request for the current branch (e.g. hub comment "A Comment")

@mislav
Copy link
Owner

mislav commented Dec 5, 2013

Yeah, there is never enough of some sort of code reviewing features. However, since I'm keeping hub strictly as a git tool, and not for anything else, I think such features would best be developed by someone else as a separate project.

It's trivial to submit a PR comment via the API but what's not trivial is to create a good conversation & reviewing experience in the command-line. Right now I would still go to the website to leave a comment, mostly because I would like to read other comments as well, comment on diffs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants