reset-console

[rouzier]

This pull request resets stdin to be read from the current console on unix based system.

To avoid the vim error 'Vim: Warning: Input is not from a terminal'

When reading in the pull request message from stdin and editing it afterwards.

For example the following command will no longer causing issues for a terminal (Which is the command I used to create this pull request)

(git rev-parse --abbrev-ref HEAD 2>/dev/null;(git diff --no-color -M --patch-with-stat  github/master...HEAD | perl -pi -e's/^/#/') )  | hub pull-request -b github:master -F - --edit

Fixes #1481

[mislav]

Interesting approach; thank you for trying to solve this!

I'm wondering whether there might be a potentially less intrusive way, i.e. one that doesn't force us to reset anything for the curent hub process.

The root of the problem is that the child vim process inherits the stdin from its parent hub process, which is undesireable in this case. Can't we simply change the stdin for the child vim process to be connected to the original terminal? Something like:

editCmd.Stdin = ...
editCmd.Spawn()

[rouzier]

Let me try that approach.

[mislav]

This looks great. I wanted to ask what would happen if tty was unavailable in the first place, for example in environments was called from a cron job or within a process that doesn't have a terminal, but opening vim wouldn't work or make sense in that case anyway, so I think we're safe like this.

Have you tried that this fixes the problem for you?

[rouzier]

Yes I have and it work perfectly.

…

On Friday, June 23, 2017, Mislav Marohnić ***@***.***> wrote: This looks great. I wanted to ask what would happen if tty was unavailable in the first place, for example in environments was called from a cron job or within a process that doesn't have a terminal, but opening vim wouldn't work or make sense in that case anyway, so I think we're safe like this. Have you tried that this fixes the problem for you? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACYBXF_hLWZQE8iCrmRMqUPdIf9-em07ks5sG7IUgaJpZM4N__Z4> .

[mislav]

Thank you for the hard work!