Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable team reviewers in pull-request #1652

Merged
merged 1 commit into from Jan 19, 2018
Merged

Enable team reviewers in pull-request #1652

merged 1 commit into from Jan 19, 2018

Conversation

@mislav
Copy link
Member

@mislav mislav commented Jan 19, 2018

Fixes #1633

@mislav mislav merged commit 0ebd0fc into master Jan 19, 2018
3 checks passed
@mislav mislav deleted the team-reviewers branch Jan 19, 2018
@axos88
Copy link

@axos88 axos88 commented Jan 20, 2018

This should also be documented

@axos88
Copy link

@axos88 axos88 commented Jan 20, 2018

Do you have any idea when the next prerelease will be available with homebrew that includes this?

@tedmdelacruz
Copy link

@tedmdelacruz tedmdelacruz commented Mar 15, 2018

@mislav Is this working? I tried hub pull-request ... -r <org_name>/<team_name> but it didn't work. I'm using version2.3.0-pre10

@mislav
Copy link
Member Author

@mislav mislav commented Mar 15, 2018

@tedmdelacruz It's in master and not yet part of any packaged release.

@johnsturgeon
Copy link

@johnsturgeon johnsturgeon commented Mar 15, 2018

When do releases get packaged?

@jasonkarns
Copy link

@jasonkarns jasonkarns commented Jun 1, 2018

Can install from master (if using macOS + homebrew) using: brew install --HEAD hub

@mislav
Copy link
Member Author

@mislav mislav commented Jun 2, 2018

Also, version 2.3.0 (including this feature) was released just the other day: https://github.com/github/hub/releases/tag/v2.3.0

@josh-g3
Copy link

@josh-g3 josh-g3 commented May 3, 2019

So this is in? And is this the proper syntax?

hub pull-request ... -r <org_name>/<team_name>

@mislav
Copy link
Member Author

@mislav mislav commented May 3, 2019

@josh-g3 Yes. Although the <org_name> part is ignored (you cannot request reviewers from an org different than the one the repo is in, anyway), so most of the time I just type hub pull-request -r/<team_name>. The slash is the only important bit to distinguish it from usernames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants