Travis #173

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@joliss
Contributor
joliss commented May 5, 2012
  • Build with MRI 1.8.7, 1.9.2, and 1.9.3 on Travis
  • Add Travis badge

Build is green: http://travis-ci.org/#!/joliss/hub
Don't forget to enable the build on http://travis-ci.org/profile

I wanted to tie down 1.8.7 compatibility with this. It's important for me for performance reasons, as Ruby 1.8.7 (as installed by apt-get) has the lowest startup time on my system.

@mislav
Member
mislav commented May 6, 2012

@defunkt, can you please enable Travis for us for this repo?

@joliss: thanks, I'm gonna merge the Travis config, but not the badge. I'm against Travis badges; I find them pointless.

@joliss
Contributor
joliss commented May 6, 2012

Cool, I've taken the badge out of the pull request.

@joliss joliss Build with MRI 1.8.7, 1.9.2, and 1.9.3 on Travis
MRI 1.8.6 should be supported by hub, but it's not supported by Travis
anymore.
84367f8
@rsanheim

Would be great to see this merged and hub mainline building on Travis.

@aspiers
aspiers commented Mar 6, 2013

@mislav Why do you find them pointless? They seem very obviously useful to me.

@mislav
Member
mislav commented Mar 6, 2013

@aspiers Because I already get notified about the build failing via email. I don't see why you, the users, should know about that. You're not maintaining the library, and you're using stable releases which are always green. You might be reading the README for a tagged version, but the Travis badge will always show the status for the latest (master) version, and if that version is red then you might be led to believe that the current version that you're reading the documentation for is broken.

@aspiers
aspiers commented Mar 6, 2013

@mislav Thanks, that's a worthwhile point of view. Although with projects like this which are (a) tools specifically for developers, and hosted on github which (b) automatically lowers the barrier to contributions via fork+pull request and (c) usually has user and developer information on the same README.md "home page", I find that the line between user and developer is often blurred, and the ratio of users who end up contributing back to the project (even in a small way) is much higher than "normal" non-developer project, e.g. Firefox. So whilst it would not make any sense at all to have build pass/fail badges on a Firefox home page, it makes a lot more sense in this context. But I take your point.

@mislav
Member
mislav commented Mar 7, 2013

@aspiers Yours are perfectly valid points, and I definitely agree a lot of hub users are or will also be contributors. However as a contributor to any of my projects, you're not dependent on Travis CI existing. You still need to write and run the tests yourself, and I'm the one who'll be merging it in and making a final decision, starting with looking did your PR break the build. So you see, Travis CI is of use mostly, if not exclusively, to project maintainers (which is just me ATM).

@aspiers
aspiers commented Mar 7, 2013

@mislav Agreed! So I guess the main advantage of the badge that it can inspire confidence in users that the maintainer is doing a good job ;-) As a potential or current user, I find that useful data :-)

@mislav
Member
mislav commented Jul 9, 2013

Ladies and gentlemen, hub is now green on Travis!

Thanks @joliss. Sorry this took so long, I didn't have admin privileges before today.

@mislav mislav closed this Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment