Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support indentation YAML #1945

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@inokappa
Copy link

commented Nov 21, 2018

Hi,

My environment is as follows.

$ ruby --version
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]

$ bundle exec gem list

*** LOCAL GEMS ***

bundler (1.16.2)
byebug (10.0.2)
hub (1.12.4)
minitest (5.11.3)

When using the following YAML in $HOME/.config/hub, I got an error(NoMethodError (undefined method []=' for nil:NilClass)) .

$ cat $HOME/.config/hub
---
github.com:
  - user: test
    oauth_token: TEST

I modified to be able to parse either YAML indentation or not.
Please confirm.

Regards.

Yohei

@inokappa inokappa changed the title fix indentation YAML Add Support indentation YAML Nov 22, 2018

@mislav

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Hi thank you for the fix! But, I'm not maintaining the 1.x line anymore. The Ruby implementation of hub is ancent and slow and you would do much better to upgrade to the latest 2.6 version.

@mislav mislav closed this Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.