ci-status with remote repository specification with -r option #462

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

Contributor
yasuoza commented Jan 14, 2014

When local repository's remotes are like:

Then run ci-status fetches always from 'michiels' remote's build status.
Because there are no 'upstream', 'github' or 'origin' remote names.
So, based on dictionary order, 'michiels' remote is choosed as a main
remote repository and there is no way to fetch 'mine' remote ci-status.

This commit make it possible to choose remote repository's commit
build status with -r option like:

hub ci-status -r mine __commit_sha__

You can also use -v option to retrieve build url:

hub ci-status -r mine __commit_sha__ -v
Member
mislav commented Jan 14, 2014

Then run ci-status fetches always from 'a-mine' remote's build status.

I consider this automatic behavior, if true, to be a bug. I'll look into this, and potentially fix it, then consider adding an explicit -r flag that you made here. Thanks for letting me know.

@yasuoza yasuoza ci-status with remote repository specification with -r option
When local repository's remotes are like:

* michiels https://github.com/michiels/pencilbox.git
* mine https://github.com/__username__/pencilbox.git

Then run `ci-status` fetches always from 'michiels' remote's build status.
Because there are no 'upstream', 'github' or 'origin' remote names.
So, based on dictionary order, 'michiels' remote is choosed as a main
remote repository and there is no way to fetch 'mine' remote ci-status.

This commit make it possible to choose remote repository's commit
build status with -r option like:

    hub ci-status -r mine __commit_sha__

You can also use -v option to retrieve build url:

    hub ci-status -r mine __commit_sha__ -v
34ae3e1
Contributor
yasuoza commented Jan 15, 2014

@mislav I misunderstood the original behavior. I updated this PR and the description. Could you review this again?

Member
mislav commented Oct 21, 2014

Closing this PR as it won't apply anymore since we nuked the Ruby implementation and replaced it with Go. #642

Sorry that this hasn't made it in. Please name your remotes in a way that hub recognized (i.e. the canonical remote should be either "origin", "github" or "upstream").

@mislav mislav closed this Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment