Merge pull request #484 from CedricGatay/fix/trac

Trac Hubot-Script
github · Jul 1, 2012 · 83e6e52 · 83e6e52
2 parents 2099b04 + 87792e0
commit 83e6e52
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/scripts/trac.coffee b/src/scripts/trac.coffee
@@ -141,12 +141,12 @@ module.exports = (robot) ->
 
         ticketid = response[0]
         issue = response[3]
-        url = process.env.HUBOT_TRAC_URL+"/ticket/"+ticketid
 
         if !ticketid
           console.log 'Error understanding trac response', ticket, response
           return
 
+        url = process.env.HUBOT_TRAC_URL+"/ticket/"+ticketid
         msg.send "Trac \##{ticketid}: #{issue.summary}. #{issue.owner} / #{issue.status}, #{issue.milestone} #{url}"
 
   # fetch a ticket using http scraping
@@ -155,7 +155,7 @@ module.exports = (robot) ->
       ['#ticket h2.summary', 'td[headers=h_owner]', '#trac-ticket-title .status', 'td[headers=h_milestone]']
       (err, response) ->
         console.log 'scrape response', response
-        url = process.env.HUBOT_TRAC_URL+"/ticket/"+ticketid
+        url = process.env.HUBOT_TRAC_URL+"/ticket/"+ticket
         msg.send "Trac \##{ticket}: #{response[0]}. #{response[1]} / #{response[2]}, #{response[3]} #{url}"
 
 
@@ -217,4 +217,4 @@ module.exports = (robot) ->
   robot.hear /([^\w]|^)r(\d+)(?=[^\w]|$)/ig, handleChangeset
   # trigger on [123]
   robot.hear /([^\w]|^)\[(\d+)\](?=[^\w]|$)/ig, handleChangeset
-
+