Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

gerrit.coffee do not use/parse full sshUrl spec and fails if we specify username #1011

Closed
renoirb opened this issue Jul 7, 2013 · 4 comments

Comments

@renoirb
Copy link

renoirb commented Jul 7, 2013

Problem

  1. The documentation block is not clear about the format to use on the sshUrl
  2. During the execution, while conneting to the remote, there is now way to know what credendials were used to connect, only says ("Permission denied (publickey).")
[Sun Jul 07 2013 05:04:07 GMT+0000 (UTC)] INFO Gerrit stream-events: Starting connection
[Sun Jul 07 2013 05:04:07 GMT+0000 (UTC)] INFO Gerrit stream-events: Permission denied (publickey).

[Sun Jul 07 2013 05:04:07 GMT+0000 (UTC)] INFO Gerrit stream-events: Connection lost (rc=255)
[Sun Jul 07 2013 05:04:08 GMT+0000 (UTC)] INFO Gerrit stream-events: Starting connection
[Sun Jul 07 2013 05:04:08 GMT+0000 (UTC)] INFO Gerrit stream-events: Permission denied (publickey).

[Sun Jul 07 2013 05:04:08 GMT+0000 (UTC)] INFO Gerrit stream-events: Connection lost (rc=255)

Suggestion

  1. Use ssh2 npm module and
  2. support full ssh url spec or allow other configuration through shell variables
@tombell
Copy link
Contributor

tombell commented Jul 7, 2013

Feel free to open a pull request to add the suggestions. Generally scripts in this repo will only get updated/fixed by people who use that script.

@renoirb
Copy link
Author

renoirb commented Jul 7, 2013

This is probably what I will come to do. I do not have an ETA for it yet, but regardless, it is useful to report it :)

@technicalpickles
Copy link
Contributor

If anyone out there is using hubot & gerrit, I'd love to see them take over maintaing this script as an external script cc #1113

@orieg
Copy link

orieg commented May 17, 2015

I will try to package it next week. I added a quick fix for the auth url. Not pretty tho.

https://github.com/orieg/hubot-gerrit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants