Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Sosearch uses ancient wwwdude, should be replaced with standard http client #700

Closed
Iristyle opened this issue Jan 11, 2013 · 3 comments
Closed

Comments

@Iristyle
Copy link
Contributor

https://github.com/github/hubot-scripts/blob/master/src/scripts/sosearch.coffee

wwwdude hasn't been updated in ages... and it looks basically dead.

Recommended to pull it out as the http client and use something native node (Hubot is 0.8 now)

/cc @carsonmcdonald

@tombell
Copy link
Contributor

tombell commented Jan 11, 2013

Does the script work?

@Iristyle
Copy link
Contributor Author

Nope, fails to load wwwdude

[Wed Jan 09 2013 21:15:21 GMT+0000 (UTC)] ERROR Unable to load /opt/hubot/releases/20130109211620/node_modules/hubot-scripts/src/scripts/sosearch: Error: Cannot find module './node-versions/v0.8.x'
Error: Cannot find module './node-versions/v0.8.x'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:362:17)
    at require (module.js:378:17)
    at Object.<anonymous> (/opt/hubot/releases/20130109211620/node_modules/wwwd$
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:362:17)

See wwwdude code

IMHO, anything using that package should be rewritten.

@carsonmcdonald
Copy link
Contributor

I'm fine letting it die. It probably wouldn't be too hard to rewrite but I'm not sure anyone is even using it.

@tombell tombell closed this as completed Jan 12, 2013
drdamour pushed a commit to drdamour/hubot-scripts that referenced this issue Mar 7, 2013
tombell pushed a commit that referenced this issue Mar 7, 2013
fixed sosearch to not use wwwdude as mentioned in #700
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants