Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow uppercase names in Asana task assignments #1155

Merged
merged 1 commit into from Feb 16, 2014

Conversation

Projects
None yet
2 participants
Contributor

buley commented Sep 27, 2013

Because the code does a toLowerCase() on the names coming from API data (https://github.com/github/hubot-scripts/blob/master/src/scripts/asana.coffee#L79), Hubot command necessarily has to take a lowercase form or the equality (https://github.com/github/hubot-scripts/blob/master/src/scripts/asana.coffee#L80) doesn't return true

task: @Taylor blah

Unable to Assign User
Task Created : blah

task: @taylor blah

Task Created : blah : Assigned to @taylor

If we toLowerCase() input data as well, the check should pass and using lowercased names in task assignments should not longer be necessary.

Cross-pulled to idpro/hubot-asana#2

@buley buley referenced this pull request in kyleknighted/hubot-asana Sep 27, 2013

Merged

hubot-asana requires @assignments to be lowercase #2

@technicalpickles technicalpickles added a commit that referenced this pull request Feb 16, 2014

@technicalpickles technicalpickles Merge pull request #1155 from editor/master
Allow uppercase names in Asana task assignments
1ab3773

@technicalpickles technicalpickles merged commit 1ab3773 into github:master Feb 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment