This repository has been archived by the owner. It is now read-only.

Fix require statement for clark #1256

Merged
merged 1 commit into from Jun 5, 2015

Conversation

Projects
None yet
3 participants
Contributor

scooter-dangle commented Dec 16, 2013

See also: #1255

Owner

technicalpickles commented Dec 18, 2013

So this is going to be a problem for existing users of this script, since the dependency is only defined in the README. We've been slowly moving to external npm packages for scripts, which can define their own dependencies directly, without affecting other scripts.

Do you have any interest in helping move this to it's own package? See #1113 for more info on what that would entail.

Contributor

scooter-dangle commented Dec 19, 2013

I'd be interested in helping but won't have time to look at it until this weekend. I'll have to check back then to see what's what and how's how.

@@ -13,7 +13,7 @@
# Author:
# ajacksified
-clark = require('clark').clark
+clark = require 'clark'
@technicalpickles

technicalpickles Dec 19, 2013

Owner

Here's another idea...

clark = require('clark')
clark = clark.clark if clark.clark? # backwards compatability with older clark versions

That should be handle both cases, and I'd be able to merge.

@scooter-dangle

scooter-dangle Jan 31, 2014

Contributor

Sorry for the slow response—a lot has happened since then (e.g., extreme cold weather vis-à-vis the pipes in the vacant apartment above mine).

Your backward compatible option looks good. Is there anything I need to do? (Do I need to change my pull request or can you just go ahead with the change?)

Contributor

scooter-dangle commented Jan 31, 2014

@ajacksified or @brntbeer (since the former mentioned you in the addition of clark to hubot-scripts #163), do either of you want to own the npm hubot-clark package? If not, I'll set it up and transfer it over to you if you change your mind at some point.

Contributor

ajacksified commented Jan 31, 2014

I don't mind either way; if you're motivated, go ahead!

technicalpickles added a commit that referenced this pull request Jun 5, 2015

Merge pull request #1256 from scooter-dangle/patch-2
Fix require statement for clark

@technicalpickles technicalpickles merged commit 1ac3d40 into github:master Jun 5, 2015

Owner

technicalpickles commented Jun 5, 2015

We are actually moving away from adding scripts to repository in favor of separate npm packages per scripts. We have already stopped accepting new scripts, and will stop accepting pull requests on this repository after hubot 3.0.

See #1113 for details. If you are interested in maintaining this longer term, check npm in case someone already made a package for it, and if not, check out https://hubot.github.com/docs/scripting/ for creating a package of your own.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.