Freshen up #1330

Merged
merged 1 commit into from Feb 17, 2014

Conversation

Projects
None yet
2 participants
Contributor

chids commented Feb 17, 2014

No description provided.

Owner

technicalpickles commented Feb 17, 2014

What exactly is this freshening up? You should be able to control the use of scripts with hubot-scripts.json without removing the entire script from this repo.

Contributor

chids commented Feb 17, 2014

I see no place for it in a official repo, or at all for that matter. If people really want this "joke" in their channels they can dig it up from the repo history or write their own.

Owner

technicalpickles commented Feb 17, 2014

That's fine. I would just say be more direct about the intent in the description.

@technicalpickles technicalpickles added a commit that referenced this pull request Feb 17, 2014

@technicalpickles technicalpickles Merge pull request #1330 from chids/patch-1
Freshen up
b31226c

@technicalpickles technicalpickles merged commit b31226c into github:master Feb 17, 2014

Contributor

chids commented Feb 18, 2014

You're absolutely right, I did it in passing. Should've put some more effort into it.

chids deleted the chids:patch-1 branch Feb 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment