This repository has been archived by the owner. It is now read-only.

github commit notifications #540

Merged
merged 1 commit into from Jan 10, 2013

Conversation

Projects
None yet
3 participants
@OleMchls
Copy link
Contributor

OleMchls commented Aug 15, 2012

Hey guys,

Intro:
With an blink of an eye, hubot will notify you and you mates when new commits are pushed to the repo.

I'm not sure about the formatting so please feel free to refactor it, to whatever fits your/our needs.

Love,

@technicalpickles

This comment has been minimized.

Copy link
Member

technicalpickles commented Sep 2, 2012

Curious, what would the advantage of using this instead of the Campfire post-commit hook? I could imagine a few cases where you want to do something special with the commit data, before posting to campfire, instead of a raw import. But, that'd always be custom, so you woudn't use a hubot-scripts script.

@OleMchls

This comment has been minimized.

Copy link
Contributor Author

OleMchls commented Sep 3, 2012

Just b/c not everybody uses campfire? I know hard to imagine, but true story bro ;) See here for possible adapters: https://github.com/github/hubot/wiki

@technicalpickles

This comment has been minimized.

Copy link
Member

technicalpickles commented Sep 5, 2012

That's just crazy talk :)

Also worth noting that the GitHub Service Hooks has an assload of different service hooks, and that it's open source.

I prefer code that someone else has to maintain ;) But, I could imagine there's less effort to use a hubot script, than getting a github-services change merged & deployed.

@OleMchls

This comment has been minimized.

Copy link
Contributor Author

OleMchls commented Sep 5, 2012

So after all what hook would you use then? And I'd prefere to have all hubot related at the same place. So building an gh-hook would be another place beside hubot/hubot-scrits where hubot related stuff would be placed.
And the effort to set this up would be almost the same. I also guess that the github-hooks guys loves code that's maintained by others.

@technicalpickles

This comment has been minimized.

Copy link
Member

technicalpickles commented Sep 5, 2012

So after all what hook would you use then?

That depends on what you are using, right? If you are using IRC, you'd use the IRC hook. If you are using Campfire, you'd use the Campfire hook, etc

So building an gh-hook would be another place beside hubot/hubot-scrits where hubot related stuff would be placed.

Not really? The GitHub service hook isn't really specific to hubot at all.

Whatever though. This is still in the running for merging.

On Sep 5, 2012, at 9:43 AM, Ole Michaelis notifications@github.com wrote:

And I'd prefere to have all hubot related at the same place. So building an gh-hook would be another place beside hubot/hubot-scrits where hubot related stuff would be placed.
And the effort to set this up would be almost the same. I also guess that the github-hooks guys loves code that's maintained by others.


Reply to this email directly or view it on GitHub.

@OleMchls

This comment has been minimized.

Copy link
Contributor Author

OleMchls commented Sep 5, 2012

I just wanna know which hook of hubot you wanna use for an gh-hook (hooking around the world :D). b/c just not having a hook would result in completely rewriting 'all' the adapters.

@technicalpickles

This comment has been minimized.

Copy link
Member

technicalpickles commented Sep 5, 2012

'whichhook of hubot'? I don't really follow what you mean, and how that would require rewriting all the adapters.

On Sep 5, 2012, at 10:11 AM, Ole Michaelis notifications@github.com wrote:

I just wanna know which hook of hubot you wanna use for an gh-hook (hooking around the world :D). b/c just not having a hook would result in completely rewriting 'all' the adapters.


Reply to this email directly or view it on GitHub.

@OleMchls

This comment has been minimized.

Copy link
Contributor Author

OleMchls commented Sep 5, 2012

yeah, don't mind. Just were confused :)

tombell pushed a commit that referenced this pull request Jan 10, 2013

@tombell tombell merged commit 20e0349 into github:master Jan 10, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.