Campfire weirdness #280

Closed
atmos opened this Issue Apr 22, 2012 · 4 comments

Projects

None yet

2 participants

@atmos
atmos commented Apr 22, 2012

Occasionally hubot takes a while to respond due to long running tasks. In the campfire adapter we store the last room a user spoke in and use that when we eventually reply with the response. We need some way to tack it onto the message and now have the response follow the user to another channel.

@tombell
tombell commented Jan 11, 2013

I remember discussing this with you. I can't remember what conclusion we came to, but the current master functionality is to put the reply into the room the user last spoke in. Can't remember if we said we want it to remember the room the incoming message came from and reply to that room or as it currently is.

//cc @atmos

@atmos
atmos commented Jan 11, 2013

I think we should be able to implement a reply based on an incoming object and not the username along. The object could keep track of the originating room, etc. I'm pretty sure this type of behavior would be ideal for all of the adapters other than shell.

@tombell
tombell commented Jan 11, 2013

Yeah, I thought the original behaviour was the reply was sent to the originating room, but after testing last night using setTimeout, the reply followed me into a 2nd room I spoke in.

@tombell
tombell commented Jan 11, 2013

See #388

@tombell tombell closed this Jan 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment