Don't try to add or remove roles for empty names #257

Merged
merged 2 commits into from Mar 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

christierney commented Mar 19, 2012

Fixes a bug where a message of the type "@hubot is that cool?" would result in a response of "I don't know anything about ."

This came up because we have another script that responds to questions like "is [something something]?" with yes-or-no answers.

christierney added some commits Mar 19, 2012

@christierney christierney Don't try to assign new roles when name is empty.
e.g. a message of the type "@hubot is that cool?" would result in
a response of "I don't know anything about ."

This conflicted with another script that responds to questions like
"is ...?".
8bdfe88
@christierney christierney Don't add/remove roles for empty names.
trim() name before checking if it matches '', and check on role
removal as well as add.
e057881

tombell merged commit 0731636 into github:master Mar 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment