Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix depercation messages #375

Closed
wants to merge 1 commit into from

3 participants

@kavu

Fixes #371. I hope that helps.

@technicalpickles

What's with the coffee-script version bump? Not that I'm opposed in general, but should isolate this request to the deprecation message fix.

@kavu kavu Fix "path.exists is now called `fs.exists`" deprecation message
Replace Path.exists with Fs.exists.
Also fixing Fs.mkdir mode param - 0o0755 was "unexpected identifier".
We need engine dependency to be sure that Heroku, for example, runs app in proper with nodejs 0.8.x in environment.
4d76b4b
@kavu

@technicalpickles, yeah, you are right. Separated this fixes.

@atmos atmos closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 15, 2012
  1. @kavu

    Fix "path.exists is now called `fs.exists`" deprecation message

    kavu authored
    Replace Path.exists with Fs.exists.
    Also fixing Fs.mkdir mode param - 0o0755 was "unexpected identifier".
    We need engine dependency to be sure that Heroku, for example, runs app in proper with nodejs 0.8.x in environment.
This page is out of date. Refresh to see the latest.
View
3  bin/hubot
@@ -73,7 +73,6 @@ unless process.platform is "win32"
if Options.create
creator = new Creator(Options.path)
creator.run()
-
else
adapterPath = Path.resolve __dirname, "..", "src", "adapters"
@@ -94,7 +93,7 @@ else
robot.load scriptsPath
scriptsFile = Path.resolve "hubot-scripts.json"
- Path.exists scriptsFile, (exists) =>
+ Fs.exists scriptsFile, (exists) =>
if exists
Fs.readFile scriptsFile, (err, data) ->
scripts = JSON.parse data
View
5 package.json
@@ -23,6 +23,11 @@
"connect_router": "1.8.6"
},
+ "engines": {
+ "node": "0.8.x",
+ "npm": "1.1.x"
+ },
+
"main": "./index",
"bin": {
View
4 src/creator.coffee
@@ -15,9 +15,9 @@ class Creator
#
# Returns nothing.
mkdirDashP: (path) ->
- Path.exists path, (exists) ->
+ Fs.exists path, (exists) ->
unless exists
- Fs.mkdir path, 0o0755, (err) ->
+ Fs.mkdir path, 0755, (err) ->
throw err if err
# Copy the contents of a file from one place to another.
View
2  src/robot.coffee
@@ -138,7 +138,7 @@ class Robot
load: (path) ->
@logger.debug "Loading scripts from #{path}"
- Path.exists path, (exists) =>
+ Fs.exists path, (exists) =>
if exists
@loadPaths.push path
for file in Fs.readdirSync(path)
Something went wrong with that request. Please try again.