Add static middleware option with CONNECT_STATIC #394

Merged
merged 1 commit into from Jan 17, 2013

Projects

None yet

2 participants

@omega
Contributor
omega commented Jan 17, 2013

Setting this to a string will allow the built in connect server to serve static files
from that directory.

I cannot for the life of me understand why my test gives the warning about documentation when robot_test does not..

@omega omega Add static middleware option with CONNECT_STATIC
Setting this to a string will allow the built in connect server to serve static files
from that directory.
fc9a661
@tombell
Contributor
tombell commented Jan 17, 2013

What's the actual use case for this, I don't want hubot to end up becoming a 'web server'.

@omega
Contributor
omega commented Jan 17, 2013

Well, for us marvin (our bots name) hosts his own homepage, and some of our scripts (like a link-collector) store stuff in redis and serves that up as html or atom using the http listener stuff. This would make it easier to serve static files (like css) along with those pages.

It just helps keep things related in the same place for our use case, but I can understand a rejection, it might be expanding a bit too much. I first tried just adding the middleware in a script, but that won't work it seems.

On Jan 17, 2013, at 5:04 PM, Tom Bell notifications@github.com wrote:

What's the actual use case for this, I don't want hubot to end up becoming a 'web server'.


Reply to this email directly or view it on GitHub.

@tombell tombell merged commit abe26de into github:master Jan 17, 2013
@omega omega deleted the omega:connect-static branch Jan 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment