Get rid of chat_services to use Hubot #71

Closed
francois2metz opened this Issue May 2, 2012 · 3 comments

Projects

None yet

2 participants

@francois2metz

Hi,

Recent versions of Hubot include an http router. It would be nice to use it to notify builds events.

Less code, less duplication and all hubot adapters will benefit from this improvement.

What do you think?

@sr
Contributor
sr commented May 2, 2012

Sounds great. I'd love to see a patch for this.

@francois2metz

I'll provide a pull request as soon as I have working code (mostly replacing room_id by room)

@francois2metz francois2metz added a commit to francois2metz/janky that referenced this issue Jun 13, 2012
@francois2metz francois2metz Initial work on hubot notifications.
Mostly remove any reference to room_id. Renamed to room as a string.
See #71.

Signed-off-by: François de Metz <francois@stormz.me>
3e5c6e4
@sr
Contributor
sr commented Jun 23, 2012

Handling this in #72.

@sr sr closed this Jun 23, 2012
@francois2metz francois2metz added a commit to francois2metz/janky that referenced this issue Oct 20, 2012
@francois2metz francois2metz Initial work on hubot notifications.
Mostly remove any reference to room_id. Renamed to room as a string.
See #71.

Signed-off-by: François de Metz <francois@stormz.me>
d089344
@francois2metz francois2metz added a commit to francois2metz/janky that referenced this issue Jan 9, 2013
@francois2metz francois2metz Initial work on hubot notifications.
Mostly remove any reference to room_id. Renamed to room as a string.
See #71.

Signed-off-by: François de Metz <francois@stormz.me>
1fabaff
@tomgr tomgr added a commit to tomgr/janky that referenced this issue Mar 14, 2013
@francois2metz @tomgr francois2metz + tomgr Initial work on hubot notifications.
Mostly remove any reference to room_id. Renamed to room as a string.
See #71.

Signed-off-by: François de Metz <francois@stormz.me>
cced3d3
@francois2metz francois2metz added a commit to francois2metz/janky that referenced this issue Mar 19, 2013
@francois2metz francois2metz Initial work on hubot notifications.
Mostly remove any reference to room_id. Renamed to room as a string.
See #71.

Signed-off-by: François de Metz <francois@stormz.me>
4fc33cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment