Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future/status of this for GitHub Pages? #9

Closed
mb21 opened this issue Oct 14, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@mb21
Copy link

commented Oct 14, 2018

What's the the plan for this for Github Pages?

I just set the markdown engine to CommonMarkGhPages for a page, and got an email warning me to better change it to kramdown. The email linked to Updating your Markdown processor to kramdown.

But as far as I know, kramdown is not commonmark-compliant, so is GitHub Pages just going to continue using a quite different flavour than the rest of github? Or was this email falsely triggered, assuming I was coming from redcarpet or something?

@kivikakk

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

Your use here is correct -- that email is being sent in error. We actually internally call that renderer gfm and have been advising users to use that value, rather than CommonMarkGhPages, and weren't sending the email out in that case. I'll fix it so both values prevent the warning email.

@kivikakk kivikakk closed this Oct 14, 2018

@mb21

This comment has been minimized.

Copy link
Author

commented Oct 15, 2018

Thanks, that's good to hear.

(I'm assuming markdown: gfm wouldn't work locally with this plugin..?)

@kivikakk

This comment has been minimized.

Copy link
Member

commented Oct 15, 2018

(I'm assuming markdown: gfm wouldn't work locally with this plugin..?)

That's correct -- we're doing it this way to hide the implementation detail of the exact name of the GFM renderer, and I didn't want to just call it jekyll-gfm. It's not clear to me that really got us anything, but oh well ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.