Support bundler local_search on 2.4.1 and higher

[JoshReedSchramm]

Description

This updates the call to local_search in bundler for the new query format on version 2.4.1 or higher.

Fixes #596

[JoshReedSchramm]

A couple notes

• I tried to maintain support for old and new versions of bundler but if there's a better way to do the version comparison I'd love the feedback.
• Given that this is for the version of bundler itself I wasn't sure how to add a test to the bundler tests for his scenario.
• Also I ran into issues trying to run tests locally even before I made this change, even after following the steps in the contributor guide.

[jonabc]

thank you so much for opening this PR! I left two suggested changes, with the suggestion for changing the version check being more critical than the other.

As a small style nit, because the change in logic between the two versions is so limited, it would be nice to have the change encapsulated to a separate method. If you'd prefer not to handle that in this PR that's totally fine, I can update it as a follow up. I'm thinking of something like

def bundler_query
  if Gem::Version.new(::Bundler::VERSION) >= Gem::Version.new("2.4.0")
    ["bundler", ::Bundler.gem_version]
  else
    Gem::Dependency.new("bundler", ::Bundler::VERSION)
  end
end

[jonabc]

• Given that this is for the version of bundler itself I wasn't sure how to add a test to the bundler tests for his scenario.

Yep agreed. The way to test this is to add '2.4' to the list of tested bundler versions in CI . If that passes with the changes in this PR then all good!

• Also I ran into issues trying to run tests locally even before I made this change, even after following the steps in the contributor guide.

Can you describe what issues you ran into? Assuming they're related to repository setup and not specific to using bundler >= 2.4.0 which is fixed by this PR, I'd love to get those fixed.

[jonabc]

oh and as one final comment, don't worry about the failing license metadata CI check. It's an issue with using a repo secret in a PR opened from a fork. I still haven't figured out a good way to get that working, and it's not a required check 🤷

[jonabc]

🚀 thanks so much for fixing this. FYI the next release, which will include this fix, will bump the major version due to containing some breaking changes in the release process outside of my control.