Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on Liquid syntax highlighting in Markdown fenced code block #3690

Closed
nhoizey opened this issue Jun 23, 2017 · 2 comments
Closed

Regression on Liquid syntax highlighting in Markdown fenced code block #3690

nhoizey opened this issue Jun 23, 2017 · 2 comments

Comments

@nhoizey
Copy link

@nhoizey nhoizey commented Jun 23, 2017

I used to use the liquid syntax highlighting in the README.md for my Jekyll Cloudinary plugin:

```liquid
{% cloudinary [preset] path/to/img.jpg [attr="value"] %}
```

But it doesn't work anymore, Github Pages refuses to generate the site because it tries to evaluate the {% cloudinary %} Liquid tag, which doesn't exist (because it comes from a plugin that is not available in Github Pages).

I had to modify my code samples to use the {% raw %} Liquid tag and the Markdown syntax highlighter:

{% raw %}
```markdown
{% cloudinary cloudflare.png alt="Un schéma montrant l'apport de Cloudflare" caption="Un schéma montrant l'apport de Cloudflare" %}
```
{% endraw %}

It's far less easy to write.

Looks like a regression, that could break a few other projects READMEs, IMHO.

@nhoizey nhoizey changed the title Regression on `liquid` syntax highlighting in Markdown fenced code block Regression on Liquid syntax highlighting in Markdown fenced code block Jun 23, 2017
@lildude

This comment has been minimized.

Copy link
Member

@lildude lildude commented Jun 23, 2017

@nhoizey Unfortunately, this isn't likely to be due to Linguist, but more likely the Markdown parser, which recently switched to be more inline with Commonmark, as detailed in A formal spec for GitHub Flavored Markdown.

Please contact our support team with these details and they'll raise an issue for this.

@lildude lildude closed this Jun 23, 2017
@tjmapes

This comment has been minimized.

Copy link

@tjmapes tjmapes commented May 5, 2018

Wow lifesaver OP. Thanks for the hint on those raw tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.