Change golang color to #3399ff #1072

Merged
merged 2 commits into from Apr 22, 2014

Conversation

Projects
None yet
10 participants
@snormore
Contributor

snormore commented Apr 16, 2014

@pchaigno

This comment has been minimized.

Show comment Hide comment
@pchaigno

pchaigno Apr 17, 2014

Collaborator

Why do you want to change the color?

Collaborator

pchaigno commented Apr 17, 2014

Why do you want to change the color?

@snormore

This comment has been minimized.

Show comment Hide comment
@snormore

snormore Apr 17, 2014

Contributor

@pchaigno blue is more indicative of Go (and the golang gopher) than the currently used brown.

Contributor

snormore commented Apr 17, 2014

@pchaigno blue is more indicative of Go (and the golang gopher) than the currently used brown.

@benbjohnson

This comment has been minimized.

Show comment Hide comment
@benbjohnson

benbjohnson Apr 17, 2014

@pchaigno Also, the currently used shade of brown isn't... well... the most flattering. :)

@pchaigno Also, the currently used shade of brown isn't... well... the most flattering. :)

@bkeepers bkeepers added the Triage label Apr 21, 2014

@arfon

This comment has been minimized.

Show comment Hide comment
@arfon

arfon Apr 21, 2014

Contributor

@snormore is there a style-guide for Go? Is this definitely the 'right' blue 😄

Contributor

arfon commented Apr 21, 2014

@snormore is there a style-guide for Go? Is this definitely the 'right' blue 😄

@snormore

This comment has been minimized.

Show comment Hide comment
@snormore

snormore Apr 22, 2014

Contributor

@arfon no color style guide afaik, but if we want to be consistent with their website colors then it would be #E0EBF5 (screenshot 2014-04-22 09 53 02) or #375EAB (screenshot 2014-04-22 10 02 47).

Contributor

snormore commented Apr 22, 2014

@arfon no color style guide afaik, but if we want to be consistent with their website colors then it would be #E0EBF5 (screenshot 2014-04-22 09 53 02) or #375EAB (screenshot 2014-04-22 10 02 47).

@arfon

This comment has been minimized.

Show comment Hide comment
@arfon

arfon Apr 22, 2014

Contributor

What do you think about updating the code in the PR to #375EAB?

Contributor

arfon commented Apr 22, 2014

What do you think about updating the code in the PR to #375EAB?

@snormore

This comment has been minimized.

Show comment Hide comment
@snormore

snormore Apr 22, 2014

Contributor

Can do, it's now set to screenshot 2014-04-22 10 02 47

Contributor

snormore commented Apr 22, 2014

Can do, it's now set to screenshot 2014-04-22 10 02 47

@arfon arfon referenced this pull request Apr 22, 2014

Merged

1072 update #1105

@arfon arfon merged commit 39e5f5b into github:master Apr 22, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@arfon

This comment has been minimized.

Show comment Hide comment
@arfon

arfon Apr 22, 2014

Contributor

Thanks @snormore

Contributor

arfon commented Apr 22, 2014

Thanks @snormore

@benbjohnson

This comment has been minimized.

Show comment Hide comment
@benbjohnson

benbjohnson Apr 22, 2014

Woohoo! Thanks @arfon.

Woohoo! Thanks @arfon.

@arfon

This comment has been minimized.

Show comment Hide comment
@arfon

arfon Apr 22, 2014

Contributor

😄 - may be another few days before we cut a new Gem for github.com but this change will get there sometime soon...

Contributor

arfon commented Apr 22, 2014

😄 - may be another few days before we cut a new Gem for github.com but this change will get there sometime soon...

@kisielk

This comment has been minimized.

Show comment Hide comment
@kisielk

kisielk Apr 22, 2014

Thanks :) The old colour always bothered me but I didn't know it would be possible to change it.

kisielk commented Apr 22, 2014

Thanks :) The old colour always bothered me but I didn't know it would be possible to change it.

@jyotiska

This comment has been minimized.

Show comment Hide comment
@jyotiska

jyotiska Apr 23, 2014

Nice. Really a minor thing, but the previous colour was kind of off-putting.

Nice. Really a minor thing, but the previous colour was kind of off-putting.

@rick

This comment has been minimized.

Show comment Hide comment
@rick

rick Apr 23, 2014

Contributor

Confirmed this is live in production now:

Contributor

rick commented Apr 23, 2014

Confirmed this is live in production now:

@arfon

This comment has been minimized.

Show comment Hide comment
@arfon

arfon Apr 23, 2014

Contributor

Lovely!

Contributor

arfon commented Apr 23, 2014

Lovely!

@benjojo

This comment has been minimized.

Show comment Hide comment
@benjojo

benjojo Apr 23, 2014

Why the change? I loved this color, it was easy to "gauge" a golang repo, now it looks like a CSS / Coffeescript repo. Makes it hard to see whats what.

Why the change? I loved this color, it was easy to "gauge" a golang repo, now it looks like a CSS / Coffeescript repo. Makes it hard to see whats what.

@luxifer

This comment has been minimized.

Show comment Hide comment
@luxifer

luxifer Apr 26, 2014

👍 @benjojo it also looks like python, really difficult to differentiate the languages only based on the color

luxifer commented Apr 26, 2014

👍 @benjojo it also looks like python, really difficult to differentiate the languages only based on the color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment