Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenEdge ABL language #115

Merged
merged 1 commit into from Mar 5, 2012

Conversation

abevoelker
Copy link
Contributor

The tests won't pass until pygments.rb gets updated to a new version of Pygments (already pull requested). They pass using a custom pygments.rb gem built from that branch.

@abevoelker
Copy link
Contributor Author

Sorry, I created the initial pull request before I realized that I didn't have any blob tests. Should I squash the two commits into one?

@josh
Copy link
Contributor

josh commented Feb 15, 2012

Its fine, still waiting on the pygments update first.

@abevoelker
Copy link
Contributor Author

pygments.rb has been updated to 0.2.6 and tests are now passing :feelsgood:

@josh
Copy link
Contributor

josh commented Mar 5, 2012

Needs to be merged with master (again).

@josh
Copy link
Contributor

josh commented Mar 5, 2012

Sorry it took so long to get pygments updated.

@abevoelker
Copy link
Contributor Author

Niceee, you guys handle rebases cleanly here (I was crossing my fingers, hehe).

No worries about pygments. That's tmm1's fault anyway, right? Hehe.

@josh
Copy link
Contributor

josh commented Mar 5, 2012

That's tmm1's fault anyway, right? Hehe.

lol.

Thanks @abevoelker, your doing some really nice patches.

josh added a commit that referenced this pull request Mar 5, 2012
Add support for OpenEdge ABL language
@josh josh merged commit 887101e into github:master Mar 5, 2012
@abevoelker
Copy link
Contributor Author

No problem, I'm glad I can give a little back to GitHub even though it is a very tiny contribution.

Should I expect "OpenEdge ABL" to show up in the list of GitHub languages sometime in the near future, or is that only for popular languages? I assume there is probably some sort of re-indexing that has to happen first so I know it's not a quick thing.

Thanks!

@pchaigno pchaigno mentioned this pull request Feb 9, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants