Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DCL and MMS/MMK files commonly used in OpenVMS environments #1573

Merged
merged 7 commits into from
Apr 10, 2015

Conversation

ztmr
Copy link
Contributor

@ztmr ztmr commented Oct 4, 2014

Search here on GitHub:

  • vms extension:mms extension:mmk gives 10,840 code results,
  • vms extension:com gives 27,922 code results.

(Note that not all the files contain vms keyword...)

@pchaigno
Copy link
Contributor

pchaigno commented Oct 4, 2014

GitHub uses Pygments for code highlighting. Currently, it doesn't have a lexer for DCL or MMS.
This is why the Travis build is failing. It also means that this code won't be highlighted on GitHub.
You should put the lexer to Text only.

@ztmr
Copy link
Contributor Author

ztmr commented Oct 4, 2014

MMS/MMK is similar to Makefile in some basic cases. Will it break something if we used Makefile's lexer to highlight as much as we can, and don't care if there are some cases where it won't work perfectly?

I don't know how Pygments works, whether it will break anything at all or simply generate inaccurate output if there was something what the lexer couldn't handle properly.

Is it acceptable to use Makefile's lexer? (It seems Pygments supports Makefile lexer, yet the Makefile format specified in languages.yaml does not refer it.)

@pchaigno
Copy link
Contributor

pchaigno commented Oct 4, 2014

I tried the Makefile lexer on MMS. It's not great: http://pygments.org/demo/707502/

@ztmr
Copy link
Contributor Author

ztmr commented Oct 4, 2014

What does it mean that DCL "has no group?" Should I remove the OpenVMS group from languages.yaml or define it somewhere else?

@pchaigno
Copy link
Contributor

pchaigno commented Oct 4, 2014

I think you can remove it.
Groups are for languages like ColdFusion CFC/ColdFusion HTML which are under the group ColdFusion. The group attribute can be seen as a parent language.

@ztmr
Copy link
Contributor Author

ztmr commented Oct 4, 2014

There was no change in Clean language, why does it fail on it? I can of course add the missing directory there but that's not point of this thread and I guess it was passing the build before...

@pchaigno
Copy link
Contributor

pchaigno commented Oct 4, 2014

That's because there is a conflict on the .dcl file extension. DCL and Clean both use it.
In those cases, the Bayesian classifier is used to distinguish the languages. It needs sample codes.

Support for the Clean language was added by @Jaxan in #682.
Maybe he would have some sample files for Clean...?

...to avoid collision with Clean language as well
as the .dcl extension can be seen only in some special
cases -- especially in context of DCL emulation tools
for non-OpenVMS systems (probably to avoid potential
confusion with MS-DOS .com files).
@arfon arfon mentioned this pull request Apr 10, 2015
@arfon arfon merged commit 08290ac into github-linguist:master Apr 10, 2015
@arfon arfon mentioned this pull request May 15, 2015
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants