New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smali language #2422

Merged
merged 2 commits into from May 28, 2015

Conversation

Projects
None yet
3 participants
@CalebFenton
Contributor

CalebFenton commented May 27, 2015

Proof that this is used frequently:
https://github.com/search?utf8=%E2%9C%93&q=extension%3Asmali+NOT+nothack&type=Code&ref=searchresults

The contribute guidelines didn't mention how I could do a full end-to-end test of this locally. But, I know the tmLanguage file works because I use it every day.

@CalebFenton

This comment has been minimized.

Show comment
Hide comment
@CalebFenton

CalebFenton May 27, 2015

Contributor

It passed tests locally, but for some reason it's including an older version of the submodule without the license. I'll fix this and do it again.

Contributor

CalebFenton commented May 27, 2015

It passed tests locally, but for some reason it's including an older version of the submodule without the license. I'll fix this and do it again.

@pchaigno

This comment has been minimized.

Show comment
Hide comment
@pchaigno

pchaigno May 27, 2015

Collaborator

Nice 👍

Collaborator

pchaigno commented May 27, 2015

Nice 👍

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon May 28, 2015

Contributor

@CalebFenton thanks for this. Looks great 👍

This will be live with the next release of Linguist (likely in the next couple of weeks)

Contributor

arfon commented May 28, 2015

@CalebFenton thanks for this. Looks great 👍

This will be live with the next release of Linguist (likely in the next couple of weeks)

arfon added a commit that referenced this pull request May 28, 2015

@arfon arfon merged commit 76d10cd into github:master May 28, 2015

2 checks passed

GitHub CLA @CalebFenton has accepted the GitHub Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arfon arfon referenced this pull request Jun 17, 2015

Merged

Cut release v4.5.6 #2456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment