New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for Zig #4005

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@jfo

jfo commented Jan 27, 2018

Hi! I'd like to add syntax support for the Zig programming Language.

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar.
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

Closes ziglang/zig#138
Closes ziglang/sublime-zig-language#1

Please let me know and thank you!

@jfo jfo force-pushed the jfo:master branch from 8c16357 to e7421bf Jan 27, 2018

@andrewrk

This comment has been minimized.

andrewrk commented Jan 29, 2018

LGTM

@jfo

This comment has been minimized.

jfo commented Feb 3, 2018

@andrewrk is Zig's original author and not a fly by rando LGTM'ing FWIW 😃

@andrewrk

This comment has been minimized.

andrewrk commented Feb 11, 2018

what's the timeline for merges?

@lildude

This comment has been minimized.

Member

lildude commented Feb 11, 2018

what's the timeline for merges?

From a quick look at the search results, I'm afraid it's going to be dependent on the growth of the use of Zig on GitHub.com and not based on anyone within the Linguist community.

Your search results show 517 files. If I remove the import keyword, this goes up to 635. If I then look into how the files of the more generous results are distributed across repos, I see they're spread across only 52 repos... which is a long way off our "used in hundreds of repositories on GitHub.com" requirement.

In short, Zig is not popular enough for this PR to be merged just yet and I've tagged this PR accordingly.

@jfo

This comment has been minimized.

jfo commented Feb 11, 2018

@lildude ok, thanks! I will update this PR with new search results as Zig grows. Is the changeset otherwise well-formed?

@lildude

This comment has been minimized.

Member

lildude commented Feb 11, 2018

Yup, LGTM.

@Alhadis Alhadis referenced this pull request Mar 1, 2018

Merged

Add script to alphabetise submodule list #4054

2 of 2 tasks complete
@ice1000

This comment has been minimized.

ice1000 commented Mar 16, 2018

image
The funnest post I've ever seen in GitHub issue comments, I saw this comment and laughed for an hour

@jfo jfo force-pushed the jfo:master branch 2 times, most recently from a5e58a2 to 15fc460 Apr 15, 2018

@jfo jfo force-pushed the jfo:master branch from 15fc460 to a0796fc Apr 15, 2018

@andrewrk

This comment has been minimized.

andrewrk commented Jun 1, 2018

I see they're spread across only 52 repos

How do you perform this search? I was unable to find this in the GitHub web interface.

@lildude

This comment has been minimized.

Member

lildude commented Jun 1, 2018

How do you perform this search? I was unable to find this in the GitHub web interface.

I have a script that queries the search API. Unfortunately, I can't share it at the moment as it abuses the API and will result in rate limiting and blocking for other peeps.

@Alhadis has a written Harvester which does something similar, but within the browser so isn't subject to API abuse rate limiting.

@pchaigno

This comment has been minimized.

Collaborator

pchaigno commented Jun 1, 2018

but within the browser so isn't subject to API abuse rate limiting.

As far as I know, it is constrained by the rate-limit as well, but there's a timer to slow down requests. I'm expecting this is okay according to the terms of service since:

Researchers may scrape public, non-personal information from GitHub for research purposes, only if any publications resulting from that research are open access.

@Alhadis

This comment has been minimized.

Collaborator

Alhadis commented Jun 1, 2018

As far as I know, it is constrained by the rate-limit as well

It is. I had to slow it down on purpose:

// Throttle the next request so GitHub doesn't bite our head off
return wait(2000).then(() => next());
@pchaigno

This comment has been minimized.

Collaborator

pchaigno commented Aug 4, 2018

Closing in favor of #4219. We'll monitor the popularity of the extension there.

If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.

@pchaigno pchaigno closed this Aug 4, 2018

@andrewrk

This comment has been minimized.

andrewrk commented Dec 1, 2018

It's time to re-open this issue. See #4219 (comment)

@andrewrk

This comment has been minimized.

andrewrk commented Dec 3, 2018

@lildude could you please re-open this issue?

@andrewrk

This comment has been minimized.

andrewrk commented Dec 5, 2018

cc @vmg

@daurnimator

This comment has been minimized.

daurnimator commented Dec 13, 2018

Any blockers here? @pchaigno could you open this PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment