Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove Rust color #4319
Conversation
pchaigno
approved these changes
Nov 10, 2018
pchaigno
requested a review
from
lildude
Nov 10, 2018
lildude
approved these changes
Nov 12, 2018
lildude
merged commit 6e7fb09
into
github:master
Nov 12, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
@pmaddams Small tip for future reference: if you put a hex colour-code inside backticks, GitHub will display a preview for it:
|
This was referenced Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
subnomo
commented
Nov 13, 2018
|
Personally not a fan of the new color, it looks too similar to Ruby. |
This comment has been minimized.
This comment has been minimized.
|
I'm also quite against this change, it was clear cut from ruby or D, now it's something in between. I even thought I'd be at the wrong place before, please change it back. |
This comment has been minimized.
This comment has been minimized.
DoumanAsh
commented
Nov 13, 2018
|
That's shitty colour |
This comment has been minimized.
This comment has been minimized.
dschuessler
commented
Nov 13, 2018
|
I am marveled that all comments on the color representing Rust code are arguing on aesthetic grounds. The main job of linguist – as far as I understand it – is making it easy to spot in which language a given source code is written. Thus linguist does its job best if colors stay the same. I don't think it is important what color is chosen for Rust as long as no one ends up intuitively thinking that Rust itself is written in Scala. As this is happening with me right now I consider this change a bug and not a feature. |
This comment has been minimized.
This comment has been minimized.
|
@dschuessler that was exactly my intention when I called for changing it back. |
This comment has been minimized.
This comment has been minimized.
midnio
commented
Nov 13, 2018
|
That's really bad |
This comment has been minimized.
This comment has been minimized.
ZhangHanDong
commented
Nov 14, 2018
|
I like new color. Give it symbolic meaning: "warm blood", "fresh blood". |
This comment has been minimized.
This comment has been minimized.
zimond
commented
Nov 14, 2018
|
Why's this happening ? The submitter is not even a rust user |
This comment has been minimized.
This comment has been minimized.
rfyiamcool
commented
Nov 14, 2018
|
oh, no .... I don't like new color . o(╥﹏╥)o |
This comment has been minimized.
This comment has been minimized.
wolfstudy
commented
Nov 14, 2018
|
oh, no .... I don't like new color . o(╥﹏╥)o |
1 similar comment
This comment has been minimized.
This comment has been minimized.
oatiz
commented
Nov 14, 2018
|
oh, no .... I don't like new color . o(╥﹏╥)o |
This comment has been minimized.
This comment has been minimized.
VitalyAnkh
commented
Nov 14, 2018
|
I don't like the new color. How can you do this without the agree of the Rust community? |
This comment has been minimized.
This comment has been minimized.
VitalyAnkh
commented
Nov 14, 2018
|
Please change the color back. |
This comment has been minimized.
This comment has been minimized.
Boiethios
commented
Nov 14, 2018
|
Everyone is used to the old color. BTW, gitlab is still using it. Why this change? |
This comment has been minimized.
This comment has been minimized.
|
Ok ok ok. I hear you. I hear you. I'll revert and get a new release out and up on GitHub before GitLab has a chance to update Linguist there, yup they use it too Locking any further comments. |
pmaddams commentedNov 9, 2018
The Rust color on GitHub doesn't look much like rust, and I don't see where it could have come from (not on the website or part of the logo). In fact, it looks rather pale and sickly, rather than vibrant and robust.
#a62c00 is much nicer. It resembles the red paints that have traditionally been made with iron oxide.