Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert rust color change #4326
Conversation
This comment has been minimized.
This comment has been minimized.
atouchet
commented
Nov 13, 2018
|
I am in favour of this. As has been mentioned in the comments of #4319 the deeper red colour is harder to distinguish from other languages (D, Ruby, Scala, etc.) while the original colour worked just fine. Also I do not believe that the #a62c00 shade has any real association with the Rust community. |
This comment has been minimized.
This comment has been minimized.
coder543
commented
Nov 13, 2018
|
FWIW, I started a humorous thread over here discussing the change. It seems like most people favor the old color, although I don't have as strong of an opinion on this subject. I slightly favor the old color. |
This comment has been minimized.
This comment has been minimized.
xtian
commented
Nov 14, 2018
•
|
I am in favor of this as well. The color that people would most associate with Rust would be that of its unofficial mascot, who is orange: http://rustacean.net Additionally, the rationale that the old color doesn't look like iron oxide is misguided since the language was named after the rust fungus, which also has an orange color: https://en.wikipedia.org/wiki/Rust_(programming_language)#History |
This comment has been minimized.
This comment has been minimized.
meme
commented
Nov 14, 2018
|
I, too, prefer the older colour. Please bring it back. Annoying that this change was done without the O.K. of the Rust team. |
This comment has been minimized.
This comment has been minimized.
quininer
commented
Nov 14, 2018
|
I think Rust color is a better choice. |
This comment has been minimized.
This comment has been minimized.
amatuni
commented
Nov 14, 2018
|
I think the new color is 10000x better than the old one. The color suggested by @quininer could be a nice compromise though. |
This comment has been minimized.
This comment has been minimized.
CharlotteMoore927
commented
Nov 14, 2018
|
the new colour is great and definitely better than the old one! |
This comment has been minimized.
This comment has been minimized.
gralpli
commented
Nov 14, 2018
•
|
It was a breaking change. We could revert it and then gradually change it to the new color over time, so no one will notice and/or complain (remember eBay, anyone?) |
This comment has been minimized.
This comment has been minimized.
elpiel
commented
Nov 14, 2018
|
I am in favor of the old one as well. It's too dark and distinguishable from other languages. |
lildude
approved these changes
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
I'll try get this out today. |
lildude
merged commit 8ad9e5f
into
github:master
Nov 14, 2018
1 check passed
github
locked as resolved and limited conversation to collaborators
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
This is now live on GitHub.com. |
0xpr03 commentedNov 13, 2018
•
edited
The previous change #4319 made it hard to distinguish the language and made it hard to recognize for all users that are used to the old color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us. Also esthetics are personal opinions, so I'd leave a new color up to the rust team to decide.