New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert rust color change #4326

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
@0xpr03
Copy link
Contributor

0xpr03 commented Nov 13, 2018

The previous change #4319 made it hard to distinguish the language and made it hard to recognize for all users that are used to the old color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us. Also esthetics are personal opinions, so I'd leave a new color up to the rust team to decide.

Revert rust color change
The previous change made it hard to distinguish and made it hard to recognize for all users that are used to the color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us.
@atouchet

This comment has been minimized.

Copy link

atouchet commented Nov 13, 2018

I am in favour of this. As has been mentioned in the comments of #4319 the deeper red colour is harder to distinguish from other languages (D, Ruby, Scala, etc.) while the original colour worked just fine. Also I do not believe that the #a62c00 shade has any real association with the Rust community.

@coder543

This comment has been minimized.

Copy link

coder543 commented Nov 13, 2018

FWIW, I started a humorous thread over here discussing the change. It seems like most people favor the old color, although I don't have as strong of an opinion on this subject. I slightly favor the old color.

@xtian

This comment has been minimized.

Copy link

xtian commented Nov 14, 2018

I am in favor of this as well. The color that people would most associate with Rust would be that of its unofficial mascot, who is orange: http://rustacean.net

Additionally, the rationale that the old color doesn't look like iron oxide is misguided since the language was named after the rust fungus, which also has an orange color: https://en.wikipedia.org/wiki/Rust_(programming_language)#History

@meme

This comment has been minimized.

Copy link

meme commented Nov 14, 2018

I, too, prefer the older colour. Please bring it back. Annoying that this change was done without the O.K. of the Rust team.

@quininer

This comment has been minimized.

Copy link

quininer commented Nov 14, 2018

I think Rust color is a better choice.

@amatuni

This comment has been minimized.

Copy link

amatuni commented Nov 14, 2018

I think the new color is 10000x better than the old one. The color suggested by @quininer could be a nice compromise though.

@CharlotteMoore927

This comment has been minimized.

Copy link

CharlotteMoore927 commented Nov 14, 2018

the new colour is great and definitely better than the old one!

@gralpli

This comment has been minimized.

Copy link

gralpli commented Nov 14, 2018

It was a breaking change. We could revert it and then gradually change it to the new color over time, so no one will notice and/or complain (remember eBay, anyone?) 😅😋

@VitalyAnkh
Copy link

VitalyAnkh left a comment

Very good.

@elpiel

This comment has been minimized.

Copy link

elpiel commented Nov 14, 2018

I am in favor of the old one as well. It's too dark and distinguishable from other languages.

@lildude

This comment has been minimized.

Copy link
Member

lildude commented Nov 14, 2018

I'll try get this out today.

@lildude lildude merged commit 8ad9e5f into github:master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@github github locked as resolved and limited conversation to collaborators Nov 14, 2018

@lildude

This comment has been minimized.

Copy link
Member

lildude commented Nov 14, 2018

This is now live on GitHub.com.

@0xpr03 0xpr03 deleted the 0xpr03:patch-1 branch Nov 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.