Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Golang color #4331

Merged
merged 3 commits into from Jan 14, 2019
Merged

Improve Golang color #4331

merged 3 commits into from Jan 14, 2019

Conversation

@0xcxdxxr
Copy link
Contributor

@0xcxdxxr 0xcxdxxr commented Nov 15, 2018

The actual color of Go doesn't looks like the color of the official Gopher mascot.

#5FC9D8 fits more to the mascot which is a bright and joyful blue turquoise.

Also the actual deep blue color (#375EAB) looks a lot like PHP (#4F5D95) & Python (#3572A5) ones.

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Nov 15, 2018

Going by Golang's style-guide, I'd say Gopher Blue #00ADD8 is the more appropriate and "official" choice of colour to represent Go.

Since this is endorsed by the Go project's official branding, I don't see too much ire being raised over this change... nonetheless, @alassanecoly should be aware of #4326 (which eventuated rather recently),. Changing the colours of well-known programming languages should be done with caution and only when project styleguides warrant it...

@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Nov 15, 2018

You're right. I directly took the color from the Gopher mascot. So does the actual color should be changed to #00ADD8 or it would be better to leave it like that ?

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Nov 15, 2018

Stick to their official blue #00ADD8. The one which looks the most "official" of the bunch. It's harder to justify a wanton colour change that doesn't start out like "...well, I thought the new colour looked more vibrant and energetic!"

@Alhadis Alhadis requested review from lildude and pchaigno Nov 15, 2018
@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Nov 15, 2018

😹 I got you

@pchaigno
Copy link
Collaborator

@pchaigno pchaigno commented Nov 15, 2018

/cc @snormore and @jredville who contributed to Linguist on Go aspects before and might have an opinion.

@pchaigno
Copy link
Collaborator

@pchaigno pchaigno commented Nov 16, 2018

The color conflicts with Dockerfile's. @alassanecoly Could you check whether changing Dockerfile's color to the second color associated with the language fixes the issue?

@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Nov 16, 2018

Before

capture d ecran 2018-11-16 a 14 18 30

After

capture d ecran 2018-11-16 a 14 20 07

@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Nov 16, 2018

Should I open a new PR to fix the issue ?

@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Nov 30, 2018

@pchaigno @lildude Any updates ?

@pchaigno
Copy link
Collaborator

@pchaigno pchaigno commented Nov 30, 2018

Did you check that changing Dockerfile to its second color fixes build failures?

@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Nov 30, 2018

@pchaigno Build fixed 🙌

@pchaigno
Copy link
Collaborator

@pchaigno pchaigno commented Dec 1, 2018

@lildude @Alhadis Do you think it's okay if we change the Dockerfile color to be able to change the Golang one? The new color for Dockerfile is selected with the same rationale as the old one.

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Dec 1, 2018

Erh, I just noticed how similar Go's new colour is to Perl's... :|

I know I'm colour-blind, but those colours look really, really similar to me, and with the recent uproar from the Rust community over the sudden colour change, I'm not sure this will sit well with many...

@lildude
Copy link
Member

@lildude lildude commented Dec 1, 2018

Yeah, I'm also a little hesitant changing the colours for a prominent language like Go after the Rust furore, especially as this PR, at a quick glimpse, almost looks like we're switching the two colours around.

The current Go colour has also been in use for nearly 5 years - this change will be noticed.

The question is how much of a stink is this likely to cause?

Maybe not much, as in both cases we're using official brand colours, and I think the proximity to Perl won't be too much of a problem either as the current colour is already close to several others and I don't think many peeps will be mixing the two, though you never know.

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Dec 1, 2018

The question is how much of a stink is this likely to cause?

Probably not nearly as much as the Rust colour change caused. We have Go's branding as a sound justification for the colour change, and googling "Go Lang" in Google Images reveals a swarth of cyan-coloured mascots. It's actually harder to justify the current colour, really.

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Dec 1, 2018

BTW... speaking strictly as a graphic designer, the headaches about colour-proximity would easily be ameliorated with a simple border:

Before

After

… adding this one line of CSS:
.language-color:not(:last-child){
	box-shadow: -1px 0 0 #fff inset;

	/* Yes, I said "border", just ignore the fact the property says "box-shadow".
	 * It's an old trick used by front-end devs to apply a cosmetic outline when
	 * the state of the box-model isn't known, and you want to avoid tampering
	 * with the physical dimensions of an element's border/content-box... */
}

Even if the colours are visually indistinguishable, there's no ambiguity where one language-block starts and another ends — and the use of a margin is more consistent with the surrounding page elements (notably the nav-bar, buttons, and even the topics list:

Of course, that's all design-speak, and I'm powerless to do anything about GitHub's visual elements. 😀 But, yeah.

@pchaigno
Copy link
Collaborator

@pchaigno pchaigno commented Dec 1, 2018

The question is how much of a stink is this likely to cause?

Should we raise the issue at https://groups.google.com/forum/#!forum/golang-nuts for this as well?

@lildude - I think @Alhadis' improvement makes a lot of sense and might also help color-blind peeps (cf #3394). Should we move it to a separate issue and ping the appropriate Githubbers?

@lildude
Copy link
Member

@lildude lildude commented Dec 3, 2018

Should we raise the issue at https://groups.google.com/forum/#!forum/golang-nuts for this as well?

That might be best. We've now got the Crystal peeps upset too 😢

@lildude - I think @Alhadis' improvement makes a lot of sense and might also help color-blind peeps (cf #3394). Should we move it to a separate issue and ping the appropriate Githubbers?

No need. We've got an issue open on the main GitHub repo already, and it includes a suggestion like @Alhadis's. I'll give it another nudge as it hasn't been touched in a while.

@0xcxdxxr
Copy link
Contributor Author

@0xcxdxxr 0xcxdxxr commented Dec 15, 2018

Should we raise the issue at https://groups.google.com/forum/#!forum/golang-nuts for this as well?

@lildude: That might be best. We've now got the Crystal peeps upset too 😢

Posted an issue at golang-nuts on december 5th: https://groups.google.com/forum/#!topic/golang-nuts/Xr_x9REPC-c.

98 views but nobody replied 😓

@Alhadis Alhadis removed request for lildude and pchaigno Jan 6, 2019
@Alhadis
Alhadis approved these changes Jan 6, 2019
Copy link
Collaborator

@Alhadis Alhadis left a comment

👍 Giving this a "LGTM", because the change is relatively uncontroversial (given it falls in line with Go's official styleguide).

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Jan 6, 2019

98 views but nobody replied 😓

22 days later, still no response. I guess we're either right to change this or they simply don't care. 😅

@0xpr03
Copy link
Contributor

@0xpr03 0xpr03 commented Jan 7, 2019

we're either right to change this or they simply don't care. sweat_smile

Or nobody of your interest is reading the mailing list ;)

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Jan 7, 2019

Heh. That's true, in a way. 😉 But out of the 111 views the topic's received, none of the readers felt strongly enough to comment. Hopefully that's indicative of the Go community at large. 🤞 If not, well, we can use Go's official styleguide as a defence.

It's possible we're being overly cautious in light of the Rust backlash. Rust's colour was changed on purely arbitrary grounds, Go's colour change is not.

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Jan 10, 2019

Nudging @lildude.

Copy link
Member

@lildude lildude left a comment

Still no comments from the wider community, but as both languages are inline with branding guidelines for each, lets go ahead with this.

@lildude lildude merged commit d178ce8 into github:master Jan 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mxplusb mxplusb mentioned this pull request Jan 14, 2019
1 task done
@leighmcculloch
Copy link

@leighmcculloch leighmcculloch commented Jan 15, 2019

This change is great, thanks for updating Go to display with the correct color. Can't wait for it go live. 🎉

@Lomanic
Copy link

@Lomanic Lomanic commented Feb 8, 2019

Don't want to be a trouble-maker but I was used for years to this color and I would have preferred it to stay unchanged.

@mattwelke
Copy link

@mattwelke mattwelke commented Feb 9, 2019

I came here from Reddit discussions about the color change. It's a shame that the community at large doesn't know about this. I had no idea that the color changing and style changes like that new white border between the colors were done publicly through PRs like this. I'm a new Go dev, and I love the new color. It makes much more sense. I also like the new white border. It was so subtle a change that I never actually noticed it, but it works great.

If I would have known about this PR I would have chimed in with my opinion, as I'm sure many other devs would have, so that it wouldn't have stagnated like that with weeks of inactivity.

@pchaigno
Copy link
Collaborator

@pchaigno pchaigno commented Feb 9, 2019

We did try to reach out to the community (see above) but it's not always obvious how to do that.

@pmaddams
Copy link
Contributor

@pmaddams pmaddams commented Feb 10, 2019

I'm the perpetrator of #4319...and I approve this change.

@mattwelke
Copy link

@mattwelke mattwelke commented Feb 10, 2019

I think this is a good example of how to do this right. @pmaddams reverted the change when the community stated they didn't like it. Here, the Go community seems to like this change. If the communities are happy, we're probably doing something right. All's well that ends well?

lildude added a commit that referenced this pull request Mar 1, 2019
In #3815, I wanted to update the Racket color to match the blue color used in the logo. Unfortunately, Go was very close in the colorspace. In #4331, Go was changed to a lighter blue. Now, with a minor tweak, the Racket color can be successfully updated from `#22228f` to `#3c5caa`.

This won't turn out like the #4319 (Rust) debacle for the following reasons:
- The blue color is official, not just a random opinion.
- We are going from a dark and not easily visible shade of blue to a lighter shade of the same color.
- Racket is not as popular as Rust, so an army of Reddit users will not show up armed with negative emojis.

Of course, if a Racket developer shows up and explains why this is a disaster, it will be easy enough to revert. But I think a nicer color will help Racket, an underappreciated Lisp dialect, look more attractive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants