New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bootstrap libraries to vendor exclude list and updated tests #637

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@borisjoffe

borisjoffe commented Aug 21, 2013

I added Twitter Bootstrap javascript and css files to the vendor exclude list and wrote tests for them which all pass. I have a repo on github where bootstrap is counted as 93% of my code.

Let me know if anything else is required.

@raphw

This comment has been minimized.

raphw commented Aug 21, 2013

This is a duplicate of what I proposed two days ago: #629

@borisjoffe

This comment has been minimized.

borisjoffe commented Aug 21, 2013

Oh, I didn't see your pull request. It seems that the regexp in #629 doesn't match "bootstrap-combined.no-icons.min.css" or "bootstrap.no-icons.min.css" though which are somewhat popular according to http://www.bootstrapcdn.com/stats.html (if you search for "bootstrap" on the top right)

@raphw

This comment has been minimized.

raphw commented Aug 21, 2013

We suggested almost concurrently, I had the same problem as you had. I fixed my regex to use a wording wildcard, as well. I thought my list was not exhaustive and I do not think anybody would use the twitter bootstrap naming space for something else, anyways.

@tnm

This comment has been minimized.

Contributor

tnm commented Nov 7, 2013

Thanks! Closing this since we've added basic support in d5002ef and we're now going to move forward with something along the lines to #417 for vendoring.

@tnm tnm closed this Nov 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment