Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

asciidoc line breaks #108

Closed
hurzl opened this Issue Apr 12, 2012 · 12 comments

Comments

Projects
None yet
10 participants

hurzl commented Apr 12, 2012

when will these be fixed?

   line1
   line2 
   line3

willall be in one line

pce commented May 13, 2012

The Reason is that the preformatted text in the pre tag is wrapped in a tt tag that has white-space: nowrap,
which means all Linebreaks get ignored.

In: https://a248.e.akamai.net/assets.github.com/stylesheets/bundles/github2-c1921b914a1a5c9fd63f1f197c5742bcc5500740.css

.markdown-body code, .markdown-body tt {
     white-space: nowrap;
}

Is there a reason to ignore Linebreaks in asciidocs preformatted text ?

hurzl commented May 13, 2012

I can't think of a reason for this and it seems easy to fix ...

Duplicate of issue #78 and issue #103...

Guys, aside of being a time-waster for the poor guy expecting things to work, it is quite ridiculous for a developer-focused service. If you don't support code blocks in asciidoc, please remove asciidoc of available formats.

Member

matthewmccullough commented Jul 18, 2012

A gist replicates this (should be two lines, is merely one):

https://gist.github.com/3134421

This means that projects with asciidoc readmes, which I'm encouraging for books, and which @schacon has in https://github.com/schacon/git-scribe and its readme are rendering instructions that folks are mistakenly following, but which are just long instructions that the command line doesn't understand.

Using web inspector, I was able to turn this on and off:

Offf

On

Rendering of code listings still seems to be broken on asciidoc documents.

I am just piping in to increase the urgency on fixing this issue.

+1

Right now I have to render my asciidoc pages and deploy them on a static Website but I would be glad to use the asciidoc-powered Wiki instead once this feature is fixed.

Bump.

Please fix this issue. Thanks.

jexp commented Oct 11, 2012

our projects use multiline asciidoc in readme's too which are rendered useless with that bug.

Member

matthewmccullough commented Oct 12, 2012

@cameronmcefee do you have any inputs on whether this appears to need a CSS change (also, #103) to cure this?

While css could technically fix this, I'd like to believe that the <tt> which causes the "problem" is styled that way for a reason. I think the better solution is to remove the <tt> tag and leave the css in place until we can sort out why it's there.

Deployed a fix that should resolve this. Please let me know if you see any issues with codeblocks elsewhere as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment