New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You don't document which library you really use for parsing markdown #1110

Closed
safinaskar opened this Issue Sep 27, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@safinaskar
Contributor

safinaskar commented Sep 27, 2017

What library you really use for parsing markdown at your production servers? It seems https://github.com/github/markup/blob/master/lib/github/markup/markdown.rb uses commonmarker if it is available, if not, then github/markdown if it is available etc. README mentions commonmarker, so it seems that you use commonmarker. But you still don't say this sufficiently clear. So, please say clearly at README what library you exactly use at your real github servers for rendering markdown

@kivikakk

This comment has been minimized.

Show comment
Hide comment
@kivikakk

kivikakk Sep 28, 2017

Member

README mentions commonmarker, so it seems that you use commonmarker.

We do use CommonMarker. Please feel free to open a PR if you feel it could be clarified in any way!

Member

kivikakk commented Sep 28, 2017

README mentions commonmarker, so it seems that you use commonmarker.

We do use CommonMarker. Please feel free to open a PR if you feel it could be clarified in any way!

@kivikakk kivikakk closed this Sep 28, 2017

@safinaskar

This comment has been minimized.

Show comment
Hide comment
@safinaskar

safinaskar Sep 28, 2017

Contributor

@kivikakk , so what you use? I cannot open a PR, because I don't know what you use for parsing markdown

Contributor

safinaskar commented Sep 28, 2017

@kivikakk , so what you use? I cannot open a PR, because I don't know what you use for parsing markdown

@kivikakk

This comment has been minimized.

Show comment
Hide comment
@kivikakk

kivikakk Sep 28, 2017

Member

As I said in my previous comment, we use CommonMarker.

Member

kivikakk commented Sep 28, 2017

As I said in my previous comment, we use CommonMarker.

@safinaskar

This comment has been minimized.

Show comment
Hide comment
@safinaskar
Contributor

safinaskar commented Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment