First try at handling Vi modelines. #56

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@chickenkiller

TODO:

  • parse only head and tail of content for obvious perf reasons
  • add emacs and kate modelines regexps (see Gedit modeline plugin)
First try at handling Vi modelines.
TODO:
 - parse only head and tail of content for obvious perf reasons
 - add emacs and kate modelines regexps (see Gedit modeline plugin)
@dagwieers

This comment has been minimized.

Show comment Hide comment
@dagwieers

dagwieers Oct 27, 2011

I like the idea a lot ! Any progress ?

I like the idea a lot ! Any progress ?

@chickenkiller

This comment has been minimized.

Show comment Hide comment
@chickenkiller

chickenkiller Oct 28, 2011

Hi Dag,

from my side, no progress on that, but it's already useable as-is so you may extend it a bit if you wish, or vote for the commit to be pushed on master branch...

Hi Dag,

from my side, no progress on that, but it's already useable as-is so you may extend it a bit if you wish, or vote for the commit to be pushed on master branch...

@dagwieers

This comment has been minimized.

Show comment Hide comment
@dagwieers

dagwieers Oct 28, 2011

I didn't know you could vote ? How ?

I didn't know you could vote ? How ?

@chickenkiller

This comment has been minimized.

Show comment Hide comment
@chickenkiller

chickenkiller Oct 28, 2011

strictly speaking you can't, I just meant you can try to make this topic relevant for github/markup devs, since I got no feedback. Commenting this push request is a good way of making them look at the issue again, so I guess you already did the job ;)

strictly speaking you can't, I just meant you can try to make this topic relevant for github/markup devs, since I got no feedback. Commenting this push request is a good way of making them look at the issue again, so I guess you already did the job ;)

@lyda

This comment has been minimized.

Show comment Hide comment
@lyda

lyda May 20, 2012

Any word on this? It would be an excellent addition. I'd like to use markdown on my projects, but really dislike README.extension.

lyda commented May 20, 2012

Any word on this? It would be an excellent addition. I'd like to use markdown on my projects, but really dislike README.extension.

@mw44118

This comment has been minimized.

Show comment Hide comment
@mw44118

mw44118 Jan 15, 2013

How do you use this? I added this modeline to my README (named README, not README.rst), and github didn't render it:

.. vim: set syntax=rst:

That modeline was on the last line of the file.

mw44118 commented Jan 15, 2013

How do you use this? I added this modeline to my README (named README, not README.rst), and github didn't render it:

.. vim: set syntax=rst:

That modeline was on the last line of the file.

@mw44118

This comment has been minimized.

Show comment Hide comment
@mw44118

mw44118 Jan 15, 2013

Is this patch running in the README render that github uses? My modeline

.. vim: set syntax=rst: ..

isn't getting noticed in my README file.

Is this patch running in the README render that github uses? My modeline

.. vim: set syntax=rst: ..

isn't getting noticed in my README file.

This comment has been minimized.

Show comment Hide comment
@chickenkiller

chickenkiller Jan 15, 2013

Owner

I don't think it has ever been looked at, so I am pretty sure it has not been integrated either. Should deserve more work before integration I guess, it's been a while.

Owner

chickenkiller replied Jan 15, 2013

I don't think it has ever been looked at, so I am pretty sure it has not been integrated either. Should deserve more work before integration I guess, it's been a while.

This comment has been minimized.

Show comment Hide comment
@mw44118

mw44118 Jan 15, 2013

@okeuday

This comment has been minimized.

Show comment Hide comment
@okeuday

okeuday Jun 14, 2013

I think that you actually want to use filetype in the vi modeline. For markdown the filetype should be "mkd". This is a concern for me because autoconf forces the text readme file to be "README", so no file extension, and github has always been unable to detect the presence of markdown within the README. It would be nice to just add ".. ex: set ft=mkd .." to solve the problem

okeuday commented Jun 14, 2013

I think that you actually want to use filetype in the vi modeline. For markdown the filetype should be "mkd". This is a concern for me because autoconf forces the text readme file to be "README", so no file extension, and github has always been unable to detect the presence of markdown within the README. It would be nice to just add ".. ex: set ft=mkd .." to solve the problem

@mw44118

This comment has been minimized.

Show comment Hide comment
@mw44118

mw44118 Jun 14, 2013

filetype or syntax?

mw44118 commented Jun 14, 2013

filetype or syntax?

@bkeepers

This comment has been minimized.

Show comment Hide comment
@bkeepers

bkeepers Jan 22, 2014

Owner

This is a really interesting idea. I'm going to close this PR out since it won't merge and you mentioned that it needs a little more work. Feel free to open a new PR after developing this further and adding some tests.

Owner

bkeepers commented Jan 22, 2014

This is a really interesting idea. I'm going to close this PR out since it won't merge and you mentioned that it needs a little more work. Feel free to open a new PR after developing this further and adding some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment