Fix git-svn #7

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@aroben
Member
aroben commented Jun 15, 2012

This pulls in msysgit/git#18 and updates the Git for Windows build to take the new Perl modules into account.

@hvoigt

Please do not change the submodules url. Once the change you need has been merged into our git.git you can use the SHA1 from there.

Member

I don't intend for this change to be pulled into msysgit/msysgit. This is just for github/msysgit, and we'll switch back to using the original remote once the git-svn fixes are present in that repository.

@hvoigt
hvoigt commented Jun 16, 2012

I see two commits and what they do but what is missing from their message is: What is the current situation? Why is this bad? Why is your change better?

Additionally I do not see the changes in the git submodule you are referencing.

@hvoigt
hvoigt commented Jun 16, 2012

Ah ok now I found the git.git change its linked in the description and here msysgit/git#18.

It looks to me as if these two commits belong together. Only with both its fixed in the installer. They tackle the same thing: Update to the git that has the fixed makefile, gitignore and copy the new files into the installer.

@aroben
Member
aroben commented Jun 16, 2012

It looks to me as if these two commits belong together. Only with both its fixed in the installer. They tackle the same thing: Update to the git that has the fixed makefile, gitignore and copy the new files into the installer.

I agree that both commits are required to fix the overall issue. But to me they seem logically distinct: one is just pulling in a new version of git.git, while the other is making changes to the installer.

@paulcbetts paulcbetts closed this Apr 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment