Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change translations approach #543

Merged
merged 1 commit into from Feb 13, 2018
Merged

Change translations approach #543

merged 1 commit into from Feb 13, 2018

Conversation

MikeMcQuaid
Copy link
Contributor

Instead of having each of the translations live on a separate GitHub Pages site that we link out to let’s get all of the translations inside this repository. This will make it easier for others to track and modify all translations as well as making changes that affect all translations in a single pass.

All existing translation PRs will need to be updated because of this but I will do my best to help everyone.

Instead of having each of the translations live on a separate GitHub
Pages site that we link out to let’s get all of the translations
inside this repository. This will make it easier for others to track
and modify all translations as well as making changes that affect all
translations in a single pass.
@@ -1,59 +0,0 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say some script for checking whether the translation is up-to-date is still needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz There will be no need to have this synced to separate repositories because all the translations will live in this repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid yes, I mean a different script. For example, there might be additional label in translated articles with the commit hash for the English version they correspond to. So that if script notices that there were some changes in the original article since that commit it might alert about translation being out-of-date.
This would be needed for translations being part of the upstream. Even further, it would be possible to enable some specific block of html in template saying that the translation is done for some of previous versions of the original article and might be out-of-date at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, such a script would be cool but I don't have the time to work on it myself I'm afraid. In my experience with Homebrew's homepage people will notice outdated translations and submit updates as PRs. Thanks for the thoughts, though! ❤️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to do a PR with such script proposal if I'll have some spare time ;)

Copy link
Contributor

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MikeMcQuaid
Copy link
Contributor Author

Merging despite red CI as Django's website is down temporarily.

@SeowCheeHsiong
Copy link

Hey! Just.txt

@mauri-wuep
Copy link

Instead of having each of the translations live on a separate GitHub Pages site that we link out to let’s get all of the translations inside this repository. This will make it easier for others to track and modify all translations as well as making changes that affect all translations in a single pass.

All existing translation PRs will need to be updated because of this but I will do my best to help everyone.

Listo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants