Added Dockerfile #17

Merged
merged 4 commits into from Jan 5, 2017

Projects

None yet

2 participants

@calind
Contributor
calind commented Dec 14, 2016

This PR adds docker support for orchestrator. It builds and installs
orchestrator in /usr/local/orchestrator and orchestrator-cli in
/usr/bin/orchestrator.

The images executes by default the orchestrator server.

It also exposes port 3000.

@shlomi-noach
Collaborator

Thank you! @rlowe are you perhaps a right person to review?

@shlomi-noach

Is it possible to have these files in some docker/ directory or do they have to be on top directory?

@calind
Contributor
calind commented Jan 4, 2017

Dockerfile and .dockerignore are better if they stay at top level. The entrypoint.sh though can be moved. If you prefer I can move the entrypoint.

@shlomi-noach
Collaborator

@calind yes, please; as much as possible let's move files outside the root dir.

calind added some commits Dec 14, 2016
@calind calind Added Dockerfile
This PR adds docker support for orchestrator. It builds and installs
orchestrator in `/usr/local/orchestrator` and `orchestrator-cli` in
`/usr/bin/orchestrator`.

The images executes by default the orchestrator server.

It also exposes port 3000.
0d1818b
@calind calind Added some docker documentation 10c1224
@calind calind Disable setting ListenAddress since docker exposes a static port 755ff1b
@calind calind Fix docker build after c419404 1d566fd
@calind
Contributor
calind commented Jan 4, 2017

@shlomi-noach, done. I have also added some documentation and fixed the docker build.

@shlomi-noach shlomi-noach merged commit 92b5c7c into github:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment