Fix build.sh which would not run correctly if run from a different directory #27

Merged
merged 2 commits into from Jan 1, 2017

Projects

None yet

2 participants

@sjmudd
Collaborator
sjmudd commented Dec 30, 2016 edited

If you run build.sh from a different directory it may not work correctly.

e.g. cd go/discovery && ../../build.sh -b gave an error due to RELEASE_VERSION not being found.

Now this works:

[myuser@myhost ~/src/orchestrator/src/github.com/github/orchestrator/go/discovery]$ export GOPATH=~/src/orchestrator
[myuser@myhost ~/src/orchestrator/src/github.com/github/orchestrator/go/discovery]$ ../../build.sh -b
Build only; no packaging
Building via go version go1.7 darwin/amd64
orchestrator binary created
binary copied to orchestrator-cli
orchestrator build done; exit status is 0
[myuser@myhost ~/src/orchestrator/src/github.com/github/orchestrator/go/discovery]$ 
@shlomi-noach shlomi-noach merged commit 513ebcf into master Jan 1, 2017

1 check passed

orchestrator-build-deploy-tarball Build #5069792 succeeded in 15s
Details
@shlomi-noach shlomi-noach deleted the build_sh_fix branch Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment