New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raft advertise #316

Merged
merged 5 commits into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@samiahlroos
Contributor

samiahlroos commented Oct 17, 2017

Related issue: #312

Description

This PR adds possibility to set RaftAdvertise in orchestrator config, and if set, uses that when setting up Raft communications.

Previously orchestrator would always set the advertise address to whatever RaftBind was set to, which fails if nodes need to communicate via NAT gateways.

If RaftAdvertise is not set, RaftBind is used which is same behavior as before this change.

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via go test ./go/...
@@ -47,6 +47,8 @@ as well as this:
],
```
If your orchestrator/raft nodes need to communicate via NAT gateways, you can additionally set "RaftAdvertise" to IP or hostname which other nodes should contact. Otherwise other nodes would try to talk to the "RaftBind" address and fail.

This comment has been minimized.

@shlomi-noach

shlomi-noach Oct 17, 2017

Collaborator

Thank you for documenting this.

@shlomi-noach

shlomi-noach Oct 17, 2017

Collaborator

Thank you for documenting this.

@shlomi-noach shlomi-noach merged commit 992507c into github:master Oct 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shlomi-noach

This comment has been minimized.

Show comment
Hide comment
@shlomi-noach

shlomi-noach Oct 19, 2017

Collaborator

Thank you!

Collaborator

shlomi-noach commented Oct 19, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment