Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance write buffer metrics v2 #682

Conversation

mateusduboli
Copy link
Contributor

@mateusduboli mateusduboli commented Nov 1, 2018

A Pull Request should be associated with an Issue.

Related issue: #113

Description

This is an alternative implementation of #676. The other code relied on a collection to store individual values and later create statistics about them. This implementation relies only on go-metrics to do this.

For this to be more elegant this also splits the instance_write_buffer from the instance_dao, to split the metric generation and reduce the general size of the instance_dao file.

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via go test ./go/...

sjmudd and others added 6 commits November 1, 2018 16:46
Add the following api calls
* /api/instance-buffered-write-metrics-raw/:seconds
* /api/instance-buffered-write-metrics-aggregated/:seconds
* also change collection name strings to constants
@mateusduboli mateusduboli force-pushed the instance-write-buffer-metrics-v2 branch from 53abffd to 3519e0f Compare November 1, 2018 15:46
@luisyonaldo luisyonaldo mentioned this pull request Aug 19, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants