Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Prettylights" development. #160

Closed
GeekinaCave opened this issue Jul 1, 2015 · 15 comments
Closed

"Prettylights" development. #160

GeekinaCave opened this issue Jul 1, 2015 · 15 comments

Comments

@GeekinaCave
Copy link

@GeekinaCave GeekinaCave commented Jul 1, 2015

Hi, i like to know is there any beta of the "Prettylights" highlighter which can be tested.

Since the mention in a forum about include rogue in pages-gem in March, there is no more info about it.

Regards.

@Stargator
Copy link
Contributor

@Stargator Stargator commented Jul 1, 2015

You can also add a gem dependency for prettylights in your jekyll site's GemFile without requiring github-pages to include it. Do you know of any issues github-pages currently has when prettylights is the highlighter used?

@GeekinaCave
Copy link
Author

@GeekinaCave GeekinaCave commented Jul 2, 2015

what is the web source for prettylights, because "rubygems.org" doesn´t found anything.
besides which is the web page for documentation of this gem?

@Stargator
Copy link
Contributor

@Stargator Stargator commented Jul 2, 2015

Well apparently, Prettylights has not been released yet. According to this comment in issue #79, Prettylights is under development and once released may become Jekyll's default syntax highlighter.

I'm 100% sure that once we release PrettyLights (our native highlighter), it will become the default in Jekyll

They seem to suggest that they are waiting to release it. If there was a beta, I think they would announce that. Prettylights will be open source, so they may have a beta for it or they may just wait until it is 1.0. Until Github announces something, we are just going to have to wait.

@geoff-nixon
Copy link
Contributor

@geoff-nixon geoff-nixon commented Jul 13, 2015

@vmg Is "PrettyLights" something different than highlights? You guys have another syntax highlighter? Are they related?

@geoff-nixon
Copy link
Contributor

@geoff-nixon geoff-nixon commented Aug 16, 2015

@vmg Never mind, I found it 😈. But I'm still unsure why not write something like a ruby version of highlights, or do something like what Chocolat does, rather than pull the TextMate code directly. Speed? Is that worth going GPL3?

@abcdiy The answer to your question is "yes"... but you'll have to dig for it yourself. Sorry.

@greyhwndz
Copy link

@greyhwndz greyhwndz commented Aug 24, 2015

Is there an update to this guys?

@vmg
Copy link

@vmg vmg commented Aug 24, 2015

I'm afraid we're not unable to open-source PrettyLights at this point because of licensing issues. I'm personally trying to work this out but since it's not entirely up to me, I cannot give an accurate timeframe. Sorry! :(

@geoff-nixon
Copy link
Contributor

@geoff-nixon geoff-nixon commented Aug 25, 2015

I'm afraid we're not unable to open-source PrettyLights at this point because of licensing issues.

Er, I'd say that's a pretty disingenuous statement. It's very clearly open source already. I wasn't going to divulge where I got the code from, but in light of the statement above, I find it somewhat unavoidable:


      LINKING EXCEPTION

In addition to the permissions in the GNU General Public License,
the author gives GitHub, Inc. unlimited permission to link the compiled
version of this library into combinations with other programs,
and to distribute those combinations without any restriction
coming from the use of this file, if such distribution is performed
by GitHub, Inc. as part of a GitHub Enterprise release.


                GNU GENERAL PUBLIC LICENSE
                    Version 3, 29 June 2007

...

So GitHub, Inc. is not required to distribute it separately due to the exception. However, since they have conveyed the software to anyone who downloads the GitHub Enterprise .ova, its within the right of anyone who downloads it to redistribute it, since you've made it available in this matter; that exception doesn't bar anyone from removing that exception and/or redistributing the code. See section 7 of the GPLv3.

To give @vmg's statement the widest interpretation I can, perhaps the issue is more accurately that GitHub does not want to distribute PrettyLights as GPL3, as most (all?) of their public "open source projects" are distributed under more liberal licenses. And they're not required to make it available separately from GitHub Enterprise, due to the exception granted by the TextMate copyright holders.

@vmg
Copy link

@vmg vmg commented Aug 25, 2015

To give @vmg's statement the widest interpretation I can, perhaps the issue is more accurately that GitHub does not want to distribute PrettyLights as GPL3, as most (all?) of their public "open source projects" are distributed under more liberal licenses. And they're not required to make it available separately from GitHub Enterprise, due to the exception granted by the TextMate copyright holders.

Thanks for adding more context to the discussion. Yes, what I meant by "we are unable to open-source it at the moment" is that we don't think a library licensed exclusively under the GPLv3 would be of much (any?) use to the community, and we're actively trying to re-license it under MIT before we make the effort to maintain a public open-source project.

That said, the source code for the library is available as part of GitHub Enterprise's source code offer, although it's not particularly interesting. Most of the big optimisations we've implemented we're also trying to upstream to TextMate (again, under the GPLv3 license), so I'm not sure what use could anybody have for the library unless you actually negotiate a license exception with TextMate's copyright holders, like we did.

In summary: as soon as we get permission to license this under MIT or BSD, we will build an open-source project around the library. And trust me, I really want this to happen. Until then, you can request the source code, but it will be of very little use because it's licensed under the GPLv3.

@geoff-nixon
Copy link
Contributor

@geoff-nixon geoff-nixon commented Aug 26, 2015

In summary: as soon as we get permission to license this under MIT or BSD, we will build an open-source project around the library. And trust me, I really want this to happen. Until then, you can request the source code, but it will be of very little use because it's licensed under the GPLv3.

That makes a lot of sense to me. Thanks for confirming/clearing this up, I appreciate it. 👍 :octocat:

@dchambers
Copy link

@dchambers dchambers commented Oct 27, 2015

You can also add a gem dependency for prettylights in your jekyll site's GemFile without requiring github-pages to include it. Do you know of any issues github-pages currently has when prettylights is the highlighter used?

@Stargator, are you suggesting that it's possible to confingure GitHub Pages to use PrettyLights instead of Pygments? If so, are you able to share some config?

@GeekinaCave
Copy link
Author

@GeekinaCave GeekinaCave commented Oct 28, 2015

Well people, officially Jekyll 3.0.0 is out.
Github Pages & Prettylights, your move.

@Stargator
Copy link
Contributor

@Stargator Stargator commented Oct 28, 2015

@dchambers If you have the prettylights gem, then I would say yes. But since Prettylights is not readily available, then I think it would be best to wait until GitHub is able to release it under a different license.

I had no prior experience/knowledge of prettylights before this issue was opened. And I still have no experience with using prettylights.

@dchambers
Copy link

@dchambers dchambers commented Oct 28, 2015

@dchambers If you have the prettylights gem, then I would say yes. But since Prettylights is not readily available, then I think it would be best to wait until GitHub is able to release it under a different license.

Ah, okay, I thought it was possible that this gem was available to processes being run on GitHub Pages, even though the gem wasn't publicly available. That being the case, I wanted to know the config needed to use it!

@benbalter
Copy link
Contributor

@benbalter benbalter commented Feb 24, 2016

Via @vmg:

I'm afraid we're not unable to open-source PrettyLights at this point because of licensing issues. I'm personally trying to work this out but since it's not entirely up to me, I cannot give an accurate timeframe.

@GeekinaCave thanks for opening the issue. Closing for now, until things change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants