Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rouge to v3.11.0 #652

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@pchaigno
Copy link
Contributor

pchaigno commented Aug 30, 2019

Supersedes #635 and #597.

Fixes #601.

@pchaigno pchaigno force-pushed the pchaigno:bump-rouge branch from 76e8fdc to ac0e724 Sep 3, 2019
@pchaigno pchaigno changed the title Bump rouge to v3.9.0 Bump rouge to v3.10.0 Sep 3, 2019
@EricFromCanada

This comment has been minimized.

Copy link

EricFromCanada commented Sep 18, 2019

Suggest rebasing and updating to rouge v3.11.0 in order to improve the highlighting in the Liquid and Jekyll docs.

pchaigno added 2 commits Aug 21, 2019
Required to update Rouge to v3.
@pchaigno pchaigno force-pushed the pchaigno:bump-rouge branch from ac0e724 to 0492303 Sep 19, 2019
@pchaigno

This comment has been minimized.

Copy link
Contributor Author

pchaigno commented Sep 19, 2019

@EricFromCanada Done. I received notifications for now Rouge releases, so I won't miss them :-)

@pchaigno pchaigno changed the title Bump rouge to v3.10.0 Bump rouge to v3.11.0 Sep 19, 2019
@pchaigno

This comment has been minimized.

Copy link
Contributor Author

pchaigno commented Sep 19, 2019

@parkr Did you get a chance to look into this?

@shopmike

This comment has been minimized.

Copy link

shopmike commented Sep 19, 2019

👍 LGTM

@parkr
parkr approved these changes Sep 30, 2019
@pchaigno

This comment has been minimized.

Copy link
Contributor Author

pchaigno commented Sep 30, 2019

@parkr Is something needed to merge this pull request? I noticed there are several other such "Bump xxxxx" pull requests you approved but didn't merge.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Sep 30, 2019

Is something needed to merge this pull request?

@pchaigno Yes! There is a bunch of automated internal testing that takes time, and some testing that requires human intervention. We try to wait to merge until we've validated the PR in the wild with Pages builds. No promises on timeline, but I'm hoping we can get this merged 🔜 !

@pchaigno

This comment has been minimized.

Copy link
Contributor Author

pchaigno commented Sep 30, 2019

Okay, thanks for the explanation!

@parkr parkr merged commit cbcd1b7 into github:master Oct 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchaigno pchaigno deleted the pchaigno:bump-rouge branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.