New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error thrown #2

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@josh
Member

josh commented Oct 2, 2018

Aligns error thrown closer to flow's invariant error.

https://github.com/zertosh/invariant/blob/fae1c859f3eec25025dc6019bf7f7fdb78a27307/browser.js#L41-L45

  • Adds an InvariantError error class mostly to satisfy the undefined framesToPop property.
  • Sets name to 'Invariant Violation' to match invariant.
  • Adds framesToPop property to indicate it's the callers fault.

@josh josh requested a review from github/web-systems Oct 2, 2018

Show outdated Hide outdated index.js Outdated

josh added some commits Oct 2, 2018

@mislav

mislav approved these changes Oct 2, 2018

@josh josh merged commit 7c4a2b3 into master Oct 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@josh josh deleted the frames-to-pop branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment