From 4d46fb2083bc5298878d026f2b4c660027a30091 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Wed, 22 May 2019 16:42:54 +0100 Subject: [PATCH 1/2] don't declare types --- src/index.js.flow | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/index.js.flow b/src/index.js.flow index 5dc42f7..90fe1e9 100644 --- a/src/index.js.flow +++ b/src/index.js.flow @@ -1,20 +1,20 @@ /* @flow strict */ declare module '@github/remote-form' { - declare type Kicker = { + type Kicker = { text: () => Promise, json: () => Promise, html: () => Promise } - declare type SimpleRequest = { + type SimpleRequest = { method: string, url: string, body: ?FormData, headers: Headers } - declare export type SimpleResponse = { + export type SimpleResponse = { url: string, status: number, statusText: ?string, @@ -23,7 +23,7 @@ declare module '@github/remote-form' { json: {[string]: any}, html: DocumentFragment } - declare export type RemoteFormHandler = (form: HTMLFormElement, kicker: Kicker, req: SimpleRequest) => void | Promise; + export type RemoteFormHandler = (form: HTMLFormElement, kicker: Kicker, req: SimpleRequest) => void | Promise; declare export function afterRemote(fn: (form: HTMLFormElement) => mixed): void; declare export function beforeRemote(fn: (form: HTMLFormElement) => mixed): void; From 69b3d5a285a7ae3ef460355f0c042be38044aa18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Wed, 22 May 2019 16:44:27 +0100 Subject: [PATCH 2/2] move flow declarations out of module scope --- src/index.js.flow | 52 +++++++++++++++++++++++------------------------ 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/src/index.js.flow b/src/index.js.flow index 90fe1e9..ef0ac86 100644 --- a/src/index.js.flow +++ b/src/index.js.flow @@ -1,32 +1,30 @@ /* @flow strict */ -declare module '@github/remote-form' { - type Kicker = { - text: () => Promise, - json: () => Promise, - html: () => Promise - } - - type SimpleRequest = { - method: string, - url: string, - body: ?FormData, - headers: Headers - } +type Kicker = { + text: () => Promise, + json: () => Promise, + html: () => Promise +} - export type SimpleResponse = { - url: string, - status: number, - statusText: ?string, - headers: Headers, - text: string, - json: {[string]: any}, - html: DocumentFragment - } - export type RemoteFormHandler = (form: HTMLFormElement, kicker: Kicker, req: SimpleRequest) => void | Promise; +type SimpleRequest = { + method: string, + url: string, + body: ?FormData, + headers: Headers +} - declare export function afterRemote(fn: (form: HTMLFormElement) => mixed): void; - declare export function beforeRemote(fn: (form: HTMLFormElement) => mixed): void; - declare export function remoteForm(selector: string, fn: RemoteFormHandler): void; - declare export function remoteUninstall(selector: string, fn: RemoteFormHandler): void; +export type SimpleResponse = { + url: string, + status: number, + statusText: ?string, + headers: Headers, + text: string, + json: {[string]: any}, + html: DocumentFragment } +export type RemoteFormHandler = (form: HTMLFormElement, kicker: Kicker, req: SimpleRequest) => void | Promise; + +declare export function afterRemote(fn: (form: HTMLFormElement) => mixed): void; +declare export function beforeRemote(fn: (form: HTMLFormElement) => mixed): void; +declare export function remoteForm(selector: string, fn: RemoteFormHandler): void; +declare export function remoteUninstall(selector: string, fn: RemoteFormHandler): void;