ActiveSupport concerning supports access modifiers #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is necessary because access modifiers within `concerning` blocks are not useless. [ActiveSupport::Module::Concerning](https://api.rubyonrails.org/classes/Module/Concerning.html)'s block creates a context in which access modifiers are respected. see rubocop/rubocop#3422 https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UselessAccessModifier
|
I'm assuming it's desirable to place this cop configuration in the rails config because the configuration is specific to ActiveSupport. |
joelhawksley
approved these changes
Aug 27, 2019
|
@joelhawksley what's the deploy process for this? just merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is necessary because access modifiers within
concerningblocks are not useless.ActiveSupport::Module::Concerning's block creates a context in which access modifiers are respected.
see rubocop/rubocop#3422
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/UselessAccessModifier