From a970f14777e4ee0ab2ab51adb5167e049d6cd9e9 Mon Sep 17 00:00:00 2001 From: Patrick Thomson Date: Fri, 7 Jun 2019 11:07:37 -0400 Subject: [PATCH 1/2] Detail patch-acceptance policy and process in CONTRIBUTING.md. We owe it to outside contributors to be clear about the process involved in submitting a patch to Semantic, and the sad fact that we won't be able to accept every proposed change. --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9a6908e138..5d8f68d2c7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -28,6 +28,8 @@ Here are a few things you can do that will increase the likelihood of your pull - Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. - Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). +Please be aware that contributions to Semantic may be sent through multiple periods of review—we are grateful for all community involvement, but because Semantic powers real systems, we must maintain a high standard of code quality. For reasons of compatibility with production Semantic uses within GitHub, we may also reject or require modifications to changes that would affect these systems. We may also reject patches that don't fit with our vision of the project; should this be the case, we encourage you to fork this S, as a healthy fork ecosystem is a sign of a robust community with varying requirements. + ## Resources - [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/) From f169c67ec8ad3795137e4dcdd1693251c6737481 Mon Sep 17 00:00:00 2001 From: Patrick Thomson Date: Fri, 7 Jun 2019 11:12:42 -0400 Subject: [PATCH 2/2] Tighten up language. --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5d8f68d2c7..5b1afd7c37 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -28,7 +28,7 @@ Here are a few things you can do that will increase the likelihood of your pull - Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. - Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). -Please be aware that contributions to Semantic may be sent through multiple periods of review—we are grateful for all community involvement, but because Semantic powers real systems, we must maintain a high standard of code quality. For reasons of compatibility with production Semantic uses within GitHub, we may also reject or require modifications to changes that would affect these systems. We may also reject patches that don't fit with our vision of the project; should this be the case, we encourage you to fork this S, as a healthy fork ecosystem is a sign of a robust community with varying requirements. +Please be aware that contributions to Semantic may be sent through multiple cycles of code review—we are grateful for all community involvement, but because Semantic powers real systems, we must maintain a high standard of code quality. For reasons of compatibility with production Semantic uses within GitHub, we may also reject or require modifications to changes that would affect these systems. We may also reject patches that don't fit with our vision of the project; should this be the case, we encourage you to start your own fork, as a healthy fork ecosystem is a sign of a robust community with varying requirements. ## Resources